[Bug 1961760] Re: `disk-image` not granular enough, often builds unused artifacts

[Ivan Kapelyukhin]

TEST CASE:
1. modified focal and bionic image's series file to use disk-image-uefi instead of disk-image
2. built the images

VERIFICATION DONE
Images are built successfully, BIOS disk images aren't built.


** Tags removed: verification-needed verification-needed-bionic verification-needed-focal
** Tags added: verification-done verification-done-bionic verification-done-focal

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/1961760

Title:
  `disk-image` not granular enough, often builds unused artifacts

Status in livecd-rootfs package in Ubuntu:
  Fix Released
Status in livecd-rootfs source package in Bionic:
  Fix Committed
Status in livecd-rootfs source package in Focal:
  Fix Committed
Status in livecd-rootfs source package in Impish:
  Fix Released

Bug description:
  [Impact]

   * Due to how `disk-image` series file in `ubuntu-cpc` is structured,
  it builds BIOS and UEFI images at the same time. However, certain
  images (e.g., GCE images) require only UEFI image to be built, BIOS
  image is being simply discarded. This results in longer build times.

  [Test Plan]

   * Build any image that depends on `disk-image` (e.g. a GCE image) with `livefs-build` or `ubuntu-bartender`
   * Read build logs and observe what build artifacts are produced: `disk.ext4` is the BIOS image and `disk-uefi.ext4` is the UEFI image

  [Where problems could occur]

   * Due to changes in the `disk-images` series file the order in which
  BIOS and UEFI image are built has changed, if there's something
  sensitive to the order in which those artifacts are built it might
  break

  [Other Info]
   
   * CPC images will be switched from `disk-image` to `disk-image-uefi` once the update is released

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1961760/+subscriptions