[Bug 1893716] Re: scripts in /etc/update-motd.d/ run even on login via non-interactive scp and sftp sessions

[Christian Ehrhardt ]

I re-installed the former package content, rebooted the system and gave
it some more memory to get rid of any concerns in that regard (from the
perf data).

The diff of the actual content before/after was all reasonable (new
times, different package counts, but otherwise the same)

Consumption wise we have:

# Before fixes
real	1m11.731s
us  sy  id  wa  st
71  20   9   0   0

    59.16%  landscape-sysin
    14.23%  swapper        
     6.16%  sshd           
     5.78%  lsb_release    
     3.35%  apt-config     
     0.86%  dbus-daemon    
     0.80%  systemd        
     0.59%  gdbus          
     0.56%  dpkg           
     0.48%  systemd-logind


# After fixes

real	0m21.257s
us  sy  id  wa  st
32  34  34   0   0

    42.00%  swapper        
    22.45%  sshd           
     2.94%  dbus-daemon    
     2.79%  systemd        
     2.08%  gdbus          
     2.07%  grep           
     1.88%  run-parts      
     1.58%  systemd-logind 
     1.46%  find           
     1.23%  bash           
     1.22%  update-motd-fsc
     1.18%  systemd-journal
     1.13%  cat

That is good.
Ready to open MRs for this.

At a very high summary:
- delay cut down by 2/3 of the initial duration
- consumption reduced by 71% (duration) and by 26% (consumption while running).
  This is multiplicative so for the example we have an saving of ~81.27% of cpu cycles

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1893716

Title:
  scripts in /etc/update-motd.d/ run even on login via non-interactive
  scp and sftp sessions

Status in landscape-client package in Ubuntu:
  In Progress
Status in pam package in Ubuntu:
  Confirmed
Status in ubuntu-release-upgrader package in Ubuntu:
  In Progress
Status in update-motd package in Ubuntu:
  Invalid
Status in update-notifier package in Ubuntu:
  In Progress

Bug description:
  My client has 200+ devices automatically uploading information via
  sftp and scp to a server every few minutes. After a recent update, I
  noticed the load on their server spiking through the roof. Upon
  investigation, I discovered a horde of landscape-sysinfo and
  /usr/bin/lsb_release processes running that correlated with login
  session notifications in /var/log/syslog and the load spikes.

  It appears that even in non-interactive sessions where this
  information will never be seen, the configuration options below in
  /etc/pam.d/sshd cause these items to be launched (in fact, probably
  everything in /etc/update-motd.d). This only started on the system in
  question after a recent set of system updates were installed.

  The content of /etc/update-motd.d/* really, really, really shouldn't
  be executed if the session in question is not interactive, as it
  provides no value at all. Unfortunately, to disable it for these non-
  interactive sessions, we also have to disable it for the interactive
  ones as well where it has some value (though not enough to make
  spiking the load on this server through the roof an acceptable
  tradeoff).

  # Print the message of the day upon successful login.
  # This includes a dynamically generated part from /run/motd.dynamic
  # and a static (admin-editable) part from /etc/motd.
  #session    optional     pam_motd.so  motd=/run/motd.dynamic
  #session    optional     pam_motd.so noupdate

  Also, looking at the script 00-header in /etc/update-motd.d/,
  /usr/bin/lsb_release is being improperly launched, as /etc/lsb_release
  does include the necessary information:

  [ -r /etc/lsb-release ] && . /etc/lsb-release

  if [ -z "$DISTRIB_DESCRIPTION" ] && [ -x /usr/bin/lsb_release ]; then
          # Fall back to using the very slow lsb_release utility
          DISTRIB_DESCRIPTION=$(lsb_release -s -d)
  fi

  # cat /etc/lsb-release
  DISTRIB_ID=Ubuntu
  DISTRIB_RELEASE=16.04
  DISTRIB_CODENAME=xenial
  DISTRIB_DESCRIPTION="Ubuntu 16.04.7 LTS"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/landscape-client/+bug/1893716/+subscriptions