[Bug 1818711] Re: never kills dnsmasq servers

[Christian Ehrhardt ]

I think this got another side effect.
needrestart detects services in their scope and so it finds dnsmasq processes using outdated libs.
Once it does it will flag "libvirtd.service" as using outdated binaries, essentially every time from that moment as - due to the lack of restarting them - that will be the case forever.

** Also affects: needrestart (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to needrestart in Ubuntu.
https://bugs.launchpad.net/bugs/1818711

Title:
  never kills dnsmasq servers

Status in libvirt package in Ubuntu:
  Triaged
Status in needrestart package in Ubuntu:
  New

Bug description:
  never kills dnsmasq servers....

  
  So on my machine, libvirtd.service spawns multiple dnsmasq daemons (one per network), yet because the libvirtd.service is set to KillMode=process these are never killed upon stopping libvirtd.

  This has a side effect that throughout the shutdown transaction,
  dnsmasq processes remain running, all the way until systemd-shutdownd
  does a final kilall spree.

  This is suboptimal.

  I don't know why libvirt has KillMode=process, but my guess is that
  one ideally wants to be able to restart libvirt without killing VMs /
  dnsmasq state. However, when doing shutdown, these should be really
  killed.

  I have a couple of "solutions". Can we like create libvirt-
  dnsmasq at .service units that would be like wantedby libvirtd.service
  (libvirt target?!). That way libvirtd can be restarted/killed without
  killing/restarting dnsmasq daemons. But these dnsmasq daemons can be
  stopped by systemd "normally" during shutdown.

  But i don't know what other processes libvirt can launch, imho all of
  them should be "systemdified" such that libvirtd.service control group
  does not contain any stray processes.

  Alternative, we might want to add a libvirt-shutdown.service that
  would do: `systemctl kill libvirtd.service` to actually kill all the
  things libvirtd might be running, after libvirtd is stopped.

  This seems to appear to affect system shutdown / reboot speed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1818711/+subscriptions