[Bug 1964510] Re: [SRU] enable signing riscv64 binaries in bionic

[Dimitri John Ledkov]

root at ethical-catfish:~# dpkg-query -W sbsigntool
sbsigntool	0.9.2-2ubuntu1~18.04.2

root at ethical-catfish:~# sbverify --cert db.crt test-arm64.efi.signed 
warning: data remaining[5112 vs 6104]: gaps between PE/COFF sections?
Signature verification OK

root at ethical-catfish:~# sbverify --cert db.crt test-riscv64.efi.signed 
warning: data remaining[5112 vs 6128]: gaps between PE/COFF sections?
Signature verification OK

root at ethical-catfish:~# faketime 'Thu May  5 13:35:03 CEST' sbsign --key ./db.key --cert ./db.crt test-arm64.efi
warning: data remaining[3584 vs 4576]: gaps between PE/COFF sections?
Signing Unsigned original image

root at ethical-catfish:~# faketime 'Thu May  5 13:35:03 CEST' sbsign --key ./db.key --cert ./db.crt test-riscv64.efi
warning: data remaining[3584 vs 4600]: gaps between PE/COFF sections?
Signing Unsigned original image

The signatures produced are identical to those made with impish tooling.

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to sbsigntool in Ubuntu.
https://bugs.launchpad.net/bugs/1964510

Title:
  [SRU] enable signing riscv64 binaries in bionic

Status in sbsigntool package in Ubuntu:
  Fix Released
Status in sbsigntool source package in Bionic:
  Fix Committed
Status in sbsigntool source package in Focal:
  Fix Committed

Bug description:
  [Impact]

  The Ubuntu signing box is running Ubuntu Bionic. The riscv64
  architecture is expanding. We expect development boards using EDK II
  to appear in 2022. We should be able to support secure boot then.

  A patch for enabling this has been accepted upstream:

  https://git.kernel.org/pub/scm/linux/kernel/git/jejb/sbsigntools.git/commit/?h=next&id=25af2eb5e39b5d54703d4489182a6b9d0af58b76

  [Test Plan]

  * Signatures produced by sbsign in bionic, must be verifiable with
  sbverify from jammy.

  * Test instructions:
    - create as new certificate RSA2048) for signing EFI binaries
      openssl req -x509 -sha256 -newkey rsa:2048 -subj /CN=TEST_$*/ \
      -keyout db.key -out db.crt -nodes -days 3650
    - sign amd64, arm64 and riscv64 EFI binaries with Bionic's sbsign
      sbsign --key db.key --cert db.crt test.efi
    - check the signature with Jammy's sbverify
    - check the signature with Bionics's sbverify

  * Testing should be executed before landing the update.

  [Where problems could occur]

  * The upstream patch is trivial and should have no effect on any non-
  riscv64 architecture. It only changes the architecture test that is
  made before signing.

  * With the test procedure above we ensure that we still can sign on
  the same architectures as before.

  [Other Info]

  * The Focal task is so that we don't loose functionality in case of an
  upgrade from Bionic to Focal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sbsigntool/+bug/1964510/+subscriptions