[Bug 1956264] Re: Cannot set offload options to false

[Lukas Märdian]

** Also affects: netplan.io (Ubuntu)
   Importance: Undecided
       Status: New

** Changed in: netplan
       Status: In Progress => Fix Committed

** Also affects: netplan.io (Ubuntu Kinetic)
   Importance: Undecided
       Status: New

** Also affects: netplan.io (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: netplan.io (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Also affects: netplan.io (Ubuntu Impish)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to netplan.io in Ubuntu.
Matching subscriptions: foundations-bugs
https://bugs.launchpad.net/bugs/1956264

Title:
  Cannot set offload options to false

Status in netplan:
  Fix Committed
Status in netplan.io package in Ubuntu:
  New
Status in netplan.io source package in Focal:
  New
Status in netplan.io source package in Impish:
  New
Status in netplan.io source package in Jammy:
  New
Status in netplan.io source package in Kinetic:
  New

Bug description:
  In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set
  the offload options that are exposed by systemd.link was added.
  Unfortunately, the implementation only allows setting the offload
  options to true. Setting the options to false results in nothing being
  written to the generated .link file, because "false" is treated the
  same as "unset" by netplan.

  See the current implementation
  https://git.launchpad.net/netplan/tree/src/networkd.c#n260.

  netplan needs to handle three different values for the offload
  options: "true", "false", and "unset"

  (I have a specific case in mind,
  https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to
  set TSO to off when using the e1000e driver. The current netplan
  implementation does not support that; as a workaround I created a
  separate .link file in /etc/systemd/network to disable TSO.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1956264/+subscriptions