[Bug 1976257] [NEW] sbuild breaks lp-buildd with symlinks to .dsc files

[Dave Jones]

Public bug reported:

We're currently carrying a delta in our sbuild which reverts a commit in
the upstream [1] which purports to fix a bug [2]. There's no bug
associated with this delta, which allegedly fixes a build failure in lp-
buildd. The delta in question is documented under d/p/abs-path-
revert.patch (I say "documented" as sbuild is a native package, so the
patch itself does nothing more than document the delta that exists in
the base tar-ball), and contains:

--- a/bin/sbuild
+++ b/bin/sbuild
@@ -84,10 +84,6 @@ sub main () {
 	my $jobname = $ARGV[0];
 	my $source_dir = 0;
 
-	if (-e $jobname) {
-	    $jobname = abs_path($jobname);
-	}
-
 	if (-d $jobname) {
 	    $jobname = create_source_package($jobname);
 	    if ($jobname eq '.') {
@@ -171,6 +167,7 @@ sub main () {
 
 sub create_source_package ($) {
     my $dsc = shift;
+    $dsc = abs_path($dsc);
 
     open(my $pipe, '-|', 'dpkg-parsechangelog',
 	 '-l' . $dsc . '/debian/changelog')

Despite digging around the bug and code history of lp-buildd around the
time the sbuild patch was introduced, I've come up empty for additional
information on why this change was introduced. As requested in the merge
LP: #1974177, I'm filing this bug largely to try and track whether this
delta is still required.

We could simply remove the patch and "see what happens" but I'm
reluctant to do that given the potentially wide-ranging breakage that
could result. Ideally, this needs some more in-depth investigation by
someone either more familiar with lp-buildd, or the time to set up a
local test environment to determine whether we should still be carrying
this patch.

[1]: https://salsa.debian.org/debian/sbuild/-/commit/d15d5ea67b81cde811207ff6853b381c3ebe4b41
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801436

** Affects: sbuild (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to sbuild in Ubuntu.
https://bugs.launchpad.net/bugs/1976257

Title:
  sbuild breaks lp-buildd with symlinks to .dsc files

Status in sbuild package in Ubuntu:
  New

Bug description:
  We're currently carrying a delta in our sbuild which reverts a commit
  in the upstream [1] which purports to fix a bug [2]. There's no bug
  associated with this delta, which allegedly fixes a build failure in
  lp-buildd. The delta in question is documented under d/p/abs-path-
  revert.patch (I say "documented" as sbuild is a native package, so the
  patch itself does nothing more than document the delta that exists in
  the base tar-ball), and contains:

  --- a/bin/sbuild
  +++ b/bin/sbuild
  @@ -84,10 +84,6 @@ sub main () {
   	my $jobname = $ARGV[0];
   	my $source_dir = 0;
   
  -	if (-e $jobname) {
  -	    $jobname = abs_path($jobname);
  -	}
  -
   	if (-d $jobname) {
   	    $jobname = create_source_package($jobname);
   	    if ($jobname eq '.') {
  @@ -171,6 +167,7 @@ sub main () {
   
   sub create_source_package ($) {
       my $dsc = shift;
  +    $dsc = abs_path($dsc);
   
       open(my $pipe, '-|', 'dpkg-parsechangelog',
   	 '-l' . $dsc . '/debian/changelog')

  Despite digging around the bug and code history of lp-buildd around
  the time the sbuild patch was introduced, I've come up empty for
  additional information on why this change was introduced. As requested
  in the merge LP: #1974177, I'm filing this bug largely to try and
  track whether this delta is still required.

  We could simply remove the patch and "see what happens" but I'm
  reluctant to do that given the potentially wide-ranging breakage that
  could result. Ideally, this needs some more in-depth investigation by
  someone either more familiar with lp-buildd, or the time to set up a
  local test environment to determine whether we should still be
  carrying this patch.

  [1]: https://salsa.debian.org/debian/sbuild/-/commit/d15d5ea67b81cde811207ff6853b381c3ebe4b41
  [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801436

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sbuild/+bug/1976257/+subscriptions