[Bug 1995247] [NEW] Leftover /tmp/apt-key.* files after updates with embedded gpg keys in deb822 sources

[Julian Andres Klode]

Public bug reported:

[Impact]
When keys are embedded into deb822 sources files as Signed-By, apt writes them to a temporary file, but the code to delete them accidentally had an if (0) in front of the deletion, so they don't get deleted and accumulate with each `apt update` run.

[Test plan]
Including a test case for this in our comprehensive integration test suite which runs as autopkgtest, so passing autopkgtest = good.

[Where problems could occur]
Files could end up being removed too soon if the code is otherwise wrong?

** Affects: apt (Ubuntu)
     Importance: High
     Assignee: Julian Andres Klode (juliank)
         Status: In Progress

** Affects: apt (Ubuntu Jammy)
     Importance: High
     Assignee: Julian Andres Klode (juliank)
         Status: Triaged

** Affects: apt (Ubuntu Kinetic)
     Importance: High
     Assignee: Julian Andres Klode (juliank)
         Status: Triaged

** Affects: apt (Ubuntu Lunar)
     Importance: High
     Assignee: Julian Andres Klode (juliank)
         Status: In Progress


** Tags: foundations-todo

** Also affects: apt (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Also affects: apt (Ubuntu Kinetic)
   Importance: Undecided
       Status: New

** Also affects: apt (Ubuntu Lunar)
   Importance: Undecided
       Status: New

** Changed in: apt (Ubuntu Lunar)
       Status: New => Triaged

** Changed in: apt (Ubuntu Kinetic)
       Status: New => Triaged

** Changed in: apt (Ubuntu Jammy)
       Status: New => Triaged

** Changed in: apt (Ubuntu Lunar)
       Status: Triaged => In Progress

** Changed in: apt (Ubuntu Jammy)
   Importance: Undecided => High

** Changed in: apt (Ubuntu Kinetic)
   Importance: Undecided => High

** Changed in: apt (Ubuntu Lunar)
   Importance: Undecided => High

** Changed in: apt (Ubuntu Jammy)
     Assignee: (unassigned) => Julian Andres Klode (juliank)

** Changed in: apt (Ubuntu Kinetic)
     Assignee: (unassigned) => Julian Andres Klode (juliank)

** Changed in: apt (Ubuntu Lunar)
     Assignee: (unassigned) => Julian Andres Klode (juliank)

** Tags added: foundations-todo

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1995247

Title:
  Leftover /tmp/apt-key.* files after updates with embedded gpg keys in
  deb822 sources

Status in apt package in Ubuntu:
  In Progress
Status in apt source package in Jammy:
  Triaged
Status in apt source package in Kinetic:
  Triaged
Status in apt source package in Lunar:
  In Progress

Bug description:
  [Impact]
  When keys are embedded into deb822 sources files as Signed-By, apt writes them to a temporary file, but the code to delete them accidentally had an if (0) in front of the deletion, so they don't get deleted and accumulate with each `apt update` run.

  [Test plan]
  Including a test case for this in our comprehensive integration test suite which runs as autopkgtest, so passing autopkgtest = good.

  [Where problems could occur]
  Files could end up being removed too soon if the code is otherwise wrong?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1995247/+subscriptions