[Bug 1964506] Re: Ping: checks payloads incorrectly, ignores all mismatch replies

[Sebastien Bacher]

@Robie, the patch description has details on the change. The github
report also discuss why the patch was broken and not just doing what is
intended and why the revert is right.

I'm not involved in iputils and will not be able to provide more
information that was in there. Note that the revert is part of 22.04.

I was mostly trying to help landing a fix we were getting request on.
I'm fine updating the testcase if that's enough to unblock the SRU but
otherwise please reject my upload, I'm not wanting to spend the time
needed to prove that upstream can be trusted on that one.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to iputils in Ubuntu.
https://bugs.launchpad.net/bugs/1964506

Title:
  Ping: checks payloads incorrectly, ignores all mismatch replies

Status in iputils package in Ubuntu:
  Fix Released
Status in iputils source package in Focal:
  Incomplete

Bug description:
  = Impact =

  the ping statistics are incorrect when dealing with truncated packets

  = Test case =

  $ ping -c 1 -s 1200 8.8.8.8

  should list truncated replies and received packets

  = Regression potential =

  the changes are limited to the ping source any regression would impact
  that utility, check that responses are correctly handled and
  statistics reflecting what is expected

  --------------------------------------------------

  Problematic commit reverted upstream causing incorrect behavior in
  Ubuntu Focal.

  Discussion: https://github.com/iputils/iputils/issues/320
  Fix: https://github.com/iputils/iputils/pull/321
  Release: https://github.com/iputils/iputils/releases/tag/20210722

  Could this patch be added for a Focal update please?

  1) Ubuntu 20.04.3 LTS
  2) 3:20190709-3
  3)

  focal$ ping -c 1 -s 1200 8.8.8.8
  PING 8.8.8.8 (8.8.8.8) 1200(1228) bytes of data.

  --- 8.8.8.8 ping statistics ---
  1 packets transmitted, 0 received, 100% packet loss, time 0ms

  4)

  xenial$ ping -c 1 -s 1200 8.8.8.8
  PING 8.8.8.8 (8.8.8.8) 1200(1228) bytes of data.
  76 bytes from 8.8.8.8: icmp_seq=1 ttl=61 (truncated)

  --- 8.8.8.8 ping statistics ---
  1 packets transmitted, 1 received, 0% packet loss, time 0ms
  rtt min/avg/max/mdev = 0.284/0.284/0.284/0.000 ms

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iputils/+bug/1964506/+subscriptions