[Bug 1988078] Re: Please backport systemd-hwdb patches to support src:systemd-hwe tests

Launchpad Bug Tracker 1988078 at bugs.launchpad.net
Thu Sep 22 09:08:57 UTC 2022 

This bug was fixed in the package systemd - 249.11-0ubuntu3.6

---------------
systemd (249.11-0ubuntu3.6) jammy; urgency=medium

  * Deny-list TEST-58-REPART on ppc64el (LP: #1988994)
    File: debian/patches/lp1988994-Deny-list-TEST-58-REPART-on-ppc64el.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=d2ed3cc1d223bf35015b15ff83b50156b58f0f38

systemd (249.11-0ubuntu3.5) jammy; urgency=medium

  [ Nick Rosbrook ]
  * Ensure dns_search_domain_unlink_marked removes all marked domains (LP: #1975667)
    File: debian/patches/lp1975667-Ensure-dns_search_domain_unlink_marked-removes-all-marked.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=919d5ddedd5bb8b45ab9437bf42d66c2821bb074
  * core,firstboot: workaround timezone issues on Ubuntu Core (LP: #1981042)
    Thanks to Robert Ancell for preparing the patch.
    File: debian/patches/lp1981042-core-firstboot-workaround-timezone-issues-caused-by-Ubunt.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b15546361b549217908fb6ca5d473be23d7fa757
  * network: do not remove localhost address (LP: #1979951)
    File: debian/patches/lp1979951-network-do-not-remove-localhost-address.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=2cd88391cce9fe95a486ae6dd214c12f236f3881
  * units: remove the restart limit on the modprobe at .service (LP: #1982462)
    File: debian/patches/lp1982462-units-remove-the-restart-limit-on-the-modprobe-.service.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=8f0acd1b2fbb8eed1259c34963e5e9b201bef900
  * pstore: do not try to load mtdpstore (LP: #1981622)
    File: debian/patches/lp1978079-efi-pstore-not-cleared-on-boot.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=15225032c3657f5906ee49d48929f9295a8664a0
  * core/mount: downgrade log level about several mkdir failures (LP: #1979952)
    Files:
    - debian/patches/lp1979952-Revert-core-mount-fail-early-if-directory-cannot-be-creat.patch
    - debian/patches/lp1979952-core-mount-downgrade-log-level-about-several-mkdir-failur.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ee8cfcf500698fab2e990de291ecf4c3ab87a4ae
  * debian/control: add Recommends: systemd-hwe-hwdb to udev.
    The systemd-hwe-hwdb brings in additional hwdb rules for HWE, so we want
    those installed with udev by default.
    File: debian/control
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=4a7a3258c33201cca305956820fcc6bcd6052d76
  * hwdb: implement --root option for systemd-hwdb query (LP: #1988078)
    Files:
    - debian/libsystemd0.symbols
    - debian/patches/lp1988078-hwdb-implement-root-option-for-systemd-hwdb-query.patch
    - debian/patches/lp1988078-sd-hwdb-add-sd_hwdb_new_from_path.patch
    - debian/patches/lp1988078-sd-hwdb-include-sys-stat.h-in-hwdb-internal.h.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=937fef96c858f2f2042bf71032f315647c14add0

  [ Luca Boccassi ]
  * Enable systemd-repart and ship it in a new systemd-repart package.
    (LP: #1897932)
    Add fdisk as test dependency, needed by test-repart which calls sfdisk.
    Add libfdisk-dev/libssl-dev as dependencies, needed for systemd-repart.
    Author: Luca Boccassi
    Files:
    - debian/control
    - debian/rules
    - debian/systemd-repart.install
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=debbc5e9362522210096ae5fa9da48378791e381

  [ Lukas Märdian ]
  * Add sd-repart as test depend, to avoid skipping TEST-58-REPART
    File: debian/tests/control
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=669190653f06a6554ddf9725cbeccac65149df23

 -- Nick Rosbrook <nick.rosbrook at canonical.com>  Fri, 09 Sep 2022
14:47:16 -0400

** Changed in: systemd (Ubuntu Jammy)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1988078

Title:
  Please backport systemd-hwdb patches to support src:systemd-hwe tests

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Jammy:
  Fix Released

Bug description:
  [Impact]

  We plan to SRU src:systemd-hwe to Jammy[1] to provide an easier way to
  SRU HWE hwdb rules to Ubuntu. The src:systemd-hwe package contains a
  test script[2] to ensure that no redundant hwdb rules are added to the
  package, i.e. rules that are already present in src:systemd. This test
  requires patches to implement --root flag support for the `systemd-
  hwdb query` command[3]. These patches are already present in kinetic.

  Without these patches in Jammy, src:systemd-hwe would have to disable
  these tests, which are important to maintaining HWE hwdb rules in
  Ubuntu.

  [1] https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug/1983996
  [2] https://git.launchpad.net/~canonical-foundations/+git/systemd-hwe/tree/tests/hwdb-redundancy?h=main
  [3] https://github.com/systemd/systemd/pull/23518

  [Test plan]

  * Create a new directory for testing hwdb rule queries:

  $ mkdir -p fakeroot/etc/udev/hwdb.d

  * Add a new .hwdb file to override an existing rule. For example, I
  chose to override the last entry from
  /lib/udev/hdwb.d/60-keyboard.hwdb:

  $ tail -2 /lib/udev/hwdb.d/60-keyboard.hwdb > fakeroot/etc/udev/hwdb.d/60-keyboard.hwdb
  $ sed -i 's/chromebook/reserved/g' fakeroot/etc/udev/hwdb.d/60-keyboard.hwdb
  $ cat fakeroot/etc/udev/hwdb.d/60-keyboard.hwdb
  evdev:atkbd:dmi:bvn*:bvr*:bd*:svnAcer*:pnPeppy:*
   XKB_FIXED_MODEL=reserved

  * Create the hwdb.bin within fakeroot:

  $ systemd-hwdb update --root fakeroot
  $ ls fakeroot/etc/udev/hwdb.bin
  fakeroot/etc/udev/hwdb.bin

  * Finally, attempt to query this new hwdb.bin using systemd-hwdb
  query. On an unpatched system, we will see results from the system's
  hwdb.bin:

  $ systemd-hwdb query --root fakeroot evdev:atkbd:dmi:bvn*:bvr*:bd*:svnAcer*:pnPeppy:* | grep XKB_FIXED_MODEL
  XKB_FIXED_MODEL=chromebook

  ...and on a patched system we should see the overridden rule:

  $ systemd-hwdb query --root fakeroot evdev:atkbd:dmi:bvn*:bvr*:bd*:svnAcer*:pnPeppy:* | grep XKB_FIXED_MODEL
  XKB_FIXED_MODEL=reserved

  [Where problems could occur]
  The patches add support for the --root flag when calling systemd-hwdb query, thus changing the behavior of this command (previously, query would always load the system's hwdb.bin). It is unlikely that existing scripts try to use the --root flag with `systemd-hwdb query`, but if they did, this is where we would see problems.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1988078/+subscriptions

More information about the foundations-bugs mailing list