[Bug 2004634] Re: Disable Ubuntu Pro registration when not online

[Nathan Teodosio]

A minor bug (raises an exception, though in a thread) has been
introduced in Bionic: Disconnecting for long enough after acquiring a
PIN will result in a call to GLib.Thread.new, an API not available in
Bionic ([1] was introduced after [2] and needs to be addressed
likewise).

[1] https://git.launchpad.net/software-properties/tree/softwareproperties/gtk/DialogUaAttach.py#n197
[2] https://git.launchpad.net/software-properties/commit/?id=5f7360ce3aaf893146885029946b3bc8a8b2c9ed

** Tags removed: verification-needed-bionic
** Tags added: verification-failed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/2004634

Title:
  Disable Ubuntu Pro registration when not online

Status in software-properties package in Ubuntu:
  Fix Committed
Status in software-properties source package in Bionic:
  Fix Committed
Status in software-properties source package in Focal:
  Fix Committed
Status in software-properties source package in Jammy:
  Fix Committed

Bug description:
  * Impact

  The current UI allows the user to try to register to Ubuntu Pro even
  when the system isn't online, which eventually leads to an error since
  the client fails to contact the server. The updated design disable the
  registration UI in those cases and inform the user they need to get
  online to be able to register which is a better experience.

  * Test Case

  - ensure that the machine isn't attached to ubuntu pro (otherwise the screen would not be displayed) and is online
  $ pro status
  and `$ pro detach` if needed

  - disconnect the system, using for example the top panel indicator

  - start software-properties-gtk and select the Ubuntu Pro tab

  - click 'Enable Ubuntu Pro'

  - The dialog controls should be disabled and a string 'Unable to
  connect to Ubuntu Pro servers. Check your internet connection.'
  displayed at the bottom

  - reconnect the system

  - the dialog control should become active and the label be removed

  - register to Ubuntu Pro, that should be working

  * Regression potential

  If the connectivity check was wrong or not reliable it could be that
  the dialog controls would be disabled even if the system is online, or
  that it would fail to detect that the system isn't connected and let
  the user try to register anyway.

  The change also adds a new translatable string. Since currently we
  don't include translations for that new UI it isn't really a
  regression. We still plan to fix that by the next languagepack update.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2004634/+subscriptions