[Bug 1999897] Re: bionic upstream branch fails to build: missing autoconf files

[Andreas Hasenack]

Hello Andreas, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/update-
notifier/3.192.1.18 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
bionic to verification-done-bionic. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-bionic. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: update-notifier (Ubuntu Bionic)
       Status: New => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1999897

Title:
  bionic upstream branch fails to build: missing autoconf files

Status in update-notifier package in Ubuntu:
  Invalid
Status in update-notifier source package in Bionic:
  Fix Committed

Bug description:
  The bionic upstream branch of update-notifier[1] currently FTBFSs.

  Compared to the source package in the ubuntu bionic archive (which builds just fine), it's missing the generated autoconf files:
  $ git diff pkg/ubuntu/bionic-devel..upstream/bionic|diffstat|grep -v /po
   Makefile.in                  |  808 ---
   aclocal.m4                   | 2290 ----------
   b/.gitignore                 |   31
   b/debian/changelog           |   10
   b/debian/control             |    2
   compile                      |  347 -
   configure                    | 9127 -------------------------------------------
   data/Makefile.in             |  649 ---
   depcomp                      |  791 ---
   install-sh                   |  508 --
   missing                      |  215 -
   pixmaps/16x16/Makefile.in    |  494 --
   pixmaps/22x22/Makefile.in    |  494 --
   pixmaps/24x24/Makefile.in    |  494 --
   pixmaps/48x48/Makefile.in    |  494 --
   pixmaps/Makefile.in          |  617 --
   pixmaps/scalable/Makefile.in |  494 --
   po/Makefile.in.in            |  221 -
   src/Makefile.in              |  715 ---
   ui/Makefile.in               |  494 --
   153 files changed, 17378 insertions(+), 32241 deletions(-)

  All other upstream branches in update-notifier have those files removed, but d/rules was adapted to generate them:
  $ git diff upstream/bionic..upstream/focal -- debian/rules
  diff --git a/debian/rules b/debian/rules
  index c67232ec..73fe23e5 100755
  --- a/debian/rules
  +++ b/debian/rules
  @@ -3,7 +3,15 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
   export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed

   %:
  -       dh $@ --with python3
  +       dh $@ --with python3 --with autoreconf
  +
  +override_dh_autoreconf:
  +       NOCONFIGURE=1 dh_autoreconf ./autogen.sh
  +
  +override_dh_auto_configure:
  +       dh_auto_configure -- --libdir=/usr/lib

   override_dh_auto_test:
          cd tests && python3 test_package-data-downloader.py
  +       cd tests && python3 test_motd.py
  +

  We should either generate these files at build time, like the other
  upstream branches, or include them in the bionic repository, like the
  current package in the bionic ubuntu archive has it[1]

  1. https://git.launchpad.net/ubuntu/+source/update-
  notifier/tree/?h=ubuntu/bionic-devel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1999897/+subscriptions