[Bug 1925265] Re: Fresh install of kinetic-preinstalled-desktop-arm64+raspi has packages to autoremove

[Steve Langasek]

this is fixed in mantic:

ubiquity (23.04.9) mantic; urgency=medium

  * bin/oem-config-remove-gtk uses aptdaemon to remove packages, not
    apt-get, so was overlooked in the previous upload.  Set the flag to
    autoremove dependencies here as well.  LP:# 1925265.

 -- Steve Langasek <steve.langasek at ubuntu.com>  Wed, 26 Apr 2023
21:51:58 +0200


** Description changed:

  [Impact]
  
  Immediately after installing hirsute-preinstalled-desktop-arm64+raspi on
  a Raspberry Pi I noticed that there were packages available for
  autoremoval.
  
  bdmurray at bdmurray-desktop:~$ sudo apt autoremove
  [sudo] password for bdmurray:
  Reading package lists... Done
  Building dependency tree... Done
  Reading state information... Done
  The following packages will be REMOVED:
    cryptsetup-bin dctrl-tools dmeventd dmraid dpkg-repack efibootmgr gir1.2-timezonemap-1.0 gir1.2-xkl-1.0 grub-common grub-efi-arm64
    grub-efi-arm64-bin grub-efi-arm64-signed grub2-common kpartx kpartx-boot libdebian-installer4 libdevmapper-event1.02.1
    libdmraid1.0.0.rc16 liblvm2cmd2.03 libtimezonemap-data libtimezonemap1 lvm2 os-prober python3-icu python3-pam rdate
    thin-provisioning-tools
  0 upgraded, 0 newly installed, 27 to remove and 0 not upgraded.
  After this operation, 45.5 MB disk space will be freed.
  Do you want to continue? [Y/n] n
  Abort.
  
  It seems to me the installation process should run an autoremove at the
  end.
  
  bdmurray at bdmurray-desktop:~$ cat /var/log/installer/version
  ubiquity 21.04.19
  
  [Test case]
  * Wait for a daily jammy preinstalled image to be built after ubiquity is accepted and built.
  * Install using the image.
  * Confirm that after installation, 'sudo apt autoremove' does not offer to remove any additional packages.
+ 
+ [Where things could go wrong]
+ Because we are now removing additional packages from the system that previously were left installed at the end of oem-config, it is possible that for some installations using oem-config - but *not* the raspi preinstalled images - that some of the packages being removed are needed to access the disk and that removal will break the boot.  The correct fix in such a case is to make sure the relevant packages are marked manually installed as part of the installation process; we already do this, but because of this bug with removals it could be that this isn't being done correctly in all cases which would only be discovered after fixing this bug.  We should handle that by making any necessary follow-up fixes to ubiquity.

** Changed in: ubiquity (Ubuntu)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1925265

Title:
  Fresh install of kinetic-preinstalled-desktop-arm64+raspi has packages
  to autoremove

Status in ubiquity package in Ubuntu:
  Fix Released
Status in ubiquity source package in Impish:
  Won't Fix
Status in ubiquity source package in Jammy:
  Triaged
Status in ubiquity source package in Kinetic:
  Won't Fix
Status in ubiquity source package in Lunar:
  Won't Fix

Bug description:
  [Impact]

  Immediately after installing hirsute-preinstalled-desktop-arm64+raspi
  on a Raspberry Pi I noticed that there were packages available for
  autoremoval.

  bdmurray at bdmurray-desktop:~$ sudo apt autoremove
  [sudo] password for bdmurray:
  Reading package lists... Done
  Building dependency tree... Done
  Reading state information... Done
  The following packages will be REMOVED:
    cryptsetup-bin dctrl-tools dmeventd dmraid dpkg-repack efibootmgr gir1.2-timezonemap-1.0 gir1.2-xkl-1.0 grub-common grub-efi-arm64
    grub-efi-arm64-bin grub-efi-arm64-signed grub2-common kpartx kpartx-boot libdebian-installer4 libdevmapper-event1.02.1
    libdmraid1.0.0.rc16 liblvm2cmd2.03 libtimezonemap-data libtimezonemap1 lvm2 os-prober python3-icu python3-pam rdate
    thin-provisioning-tools
  0 upgraded, 0 newly installed, 27 to remove and 0 not upgraded.
  After this operation, 45.5 MB disk space will be freed.
  Do you want to continue? [Y/n] n
  Abort.

  It seems to me the installation process should run an autoremove at
  the end.

  bdmurray at bdmurray-desktop:~$ cat /var/log/installer/version
  ubiquity 21.04.19

  [Test case]
  * Wait for a daily jammy preinstalled image to be built after ubiquity is accepted and built.
  * Install using the image.
  * Confirm that after installation, 'sudo apt autoremove' does not offer to remove any additional packages.

  [Where things could go wrong]
  Because we are now removing additional packages from the system that previously were left installed at the end of oem-config, it is possible that for some installations using oem-config - but *not* the raspi preinstalled images - that some of the packages being removed are needed to access the disk and that removal will break the boot.  The correct fix in such a case is to make sure the relevant packages are marked manually installed as part of the installation process; we already do this, but because of this bug with removals it could be that this isn't being done correctly in all cases which would only be discovered after fixing this bug.  We should handle that by making any necessary follow-up fixes to ubiquity.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1925265/+subscriptions