[Bug 2021498] Re: Please merge 3.134 into mantic

Benjamin Drung 2021498 at bugs.launchpad.net
Thu Jun 15 16:24:23 UTC 2023


I reviewed https://salsa.debian.org/mateus-
morais/adduser/-/tree/ubuntu/devel since that was the easiest way for
me. I have some remarks:

* Your ubuntu/devel branch should be based on the released commit (The top commit "prepare new version" is not released yet)
* The rebase/merge for doc/adduser.8 looks incorrect (see comment on https://salsa.debian.org/debian/adduser/-/merge_requests/87)
* Will you add the test case for https://salsa.debian.org/debian/adduser/-/merge_requests/87 to the Ubuntu package?
* The upstream changes to adduser.conf should be incorporated in our rebase/merge (see commit "Enable private home directories by default" and "Allow uppercase letters in the names of system users")
* Please forward the two d/t/f/firstlastuidgid.t fixes to Debian (you can reference the merge request numbers in d/changelog then)
* "Fix failing tests by smartly incrementing test uids and gids" add some trailing spaces to d/t/f/firstlastuidgid.t
* d/changelog: "Rename NAME_REGEX_SYSTEM to SYS_NAME_REGEX" should be dropped. And "AdduserCommon.pm, adduser.conf: Change default SYS_NAME_REGEX to allow uppercase letters in the names of system users" should be moved to the "Remaining changes" list.

I unsubscribed ~ubuntu-sponsors.

** Changed in: adduser (Ubuntu)
     Assignee: Benjamin Drung (bdrung) => Mateus Rodrigues de Morais (mateus-morais)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to adduser in Ubuntu.
https://bugs.launchpad.net/bugs/2021498

Title:
  Please merge 3.134 into mantic

Status in adduser package in Ubuntu:
  In Progress

Bug description:
  The upstream version 3.134 should be merged into mantic. The current
  version is 3.129ubuntu1.

  See the merge conflict report:
  https://merges.ubuntu.com/a/adduser/REPORT

  Note: this is a tracking bug

  PPA for review: https://launchpad.net/~mateus-
  morais/+archive/ubuntu/adduser-merge-mantic-3.134-lp2021498

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adduser/+bug/2021498/+subscriptions




More information about the foundations-bugs mailing list