[Bug 2009756] Re: backups fail since latest rsync security update

[Aurélien Gâteau]

Hi Mark,

I just tested it. Unfortunately the package fails to install:

```
Preparing to unpack .../backintime-common_1.2.1-3ubuntu0.2_all.deb ...
Unpacking backintime-common (1.2.1-3ubuntu0.2) over (1.2.1-3ubuntu0.2) ...
Preparing to unpack .../backintime-qt_1.2.1-3ubuntu0.2_all.deb ...
Unpacking backintime-qt (1.2.1-3ubuntu0.2) over (1.2.1-3ubuntu0.2) ...
Setting up backintime-common (1.2.1-3ubuntu0.2) ...
  File "/usr/share/backintime/common/snapshots.py", line 596
    sid.path(use_mode = ['ssh', 'ssh_encfs'])
    ^^^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?
dpkg: error processing package backintime-common (--install):
 installed backintime-common package post-installation script subprocess returned error exit status 1
dpkg: dependency problems prevent configuration of backintime-qt:
 backintime-qt depends on backintime-common (= 1.2.1-3ubuntu0.2); however:
  Package backintime-common is not configured yet.
```

After looking at the code, I think line 596 is indeed missing a comma at
the end.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rsync in Ubuntu.
https://bugs.launchpad.net/bugs/2009756

Title:
  backups fail since latest rsync security update

Status in backintime package in Ubuntu:
  Fix Released
Status in rsync package in Ubuntu:
  New
Status in backintime source package in Jammy:
  In Progress
Status in rsync source package in Jammy:
  New
Status in backintime source package in Kinetic:
  In Progress
Status in rsync source package in Kinetic:
  New
Status in backintime source package in Lunar:
  Fix Released
Status in rsync source package in Lunar:
  New

Bug description:
  Backintime uses rsync to perform updates. Unfortunately there is an
  incompatibility between the currently released version of backintime
  and rsync >= 3.2.4 (see https://github.com/bit-
  team/backintime/issues/1247)

  Rsync has been updated from 3.2.3 to 3.2.7 on Feb 27. This broke
  backintime backups. The symptom is an error message like this:

  Command "rsync -a --delete --rsh=ssh -o ServerAliveInterval=240 -o
  LogLevel=Error -o IdentityFile=/home/aurelien/.ssh/backintime -p 22
  /tmp/tmpxilwcwk4/
  user at example.com:"./backintime/switch/aurelien/1/20230308-230517-262""
  returns 3 | rsync: change_dir#3
  "/data/home/user//"./backintime/switch/aurelien/1" failed: No such
  file or directory (2)

  The workaround described in the GitHub issue works (passing `--old-
  args` to rsync), but maybe it would be better if the backintime
  package did this automatically?

  ProblemType: Bug
  DistroRelease: Ubuntu 22.04
  Package: backintime-common 1.2.1-3ubuntu0.1
  ProcVersionSignature: Ubuntu 5.19.0-35.36~22.04.1-generic 5.19.17
  Uname: Linux 5.19.0-35-generic x86_64
  ApportVersion: 2.20.11-0ubuntu82.3
  Architecture: amd64
  CasperMD5CheckResult: unknown
  CurrentDesktop: KDE
  Date: Wed Mar  8 23:19:02 2023
  InstallationDate: Installed on 2021-06-23 (623 days ago)
  InstallationMedia: Kubuntu 20.04.2.0 LTS "Focal Fossa" - Release amd64 (20210209.1)
  PackageArchitecture: all
  SourcePackage: backintime
  UpgradeStatus: Upgraded to jammy on 2022-08-24 (196 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/backintime/+bug/2009756/+subscriptions