[Bug 2037584] Re: ubuntu-pro-client-l10n translations are stripped

[Renan Rodrigo]

As part of the validation process for
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-
tools/+bug/2038461, as mentioned in the test plan, we ran tests which
depended on pkgbinarymangler proposed version to run. Those are the
i18n.feature tests, which failed before, as the translations were
stripped. The tests are passing now.

The ubuntu-advantage-tools package in -proposed has been built with this
-proposed version of pkgbinarymangler (checked amd64 for simplicity):

ubuntu-advantage-tools 30~16.04 was built with
pkgbinarymangler 129.16.04.0
(from build log https://launchpadlibrarian.net/697068643/buildlog_ubuntu-xenial-amd64.ubuntu-advantage-tools_30~16.04_BUILDING.txt.gz)

ubuntu-advantage-tools 30~18.04 was built with
pkgbinarymangler 138.18.04.2
(from build log https://launchpadlibrarian.net/697068270/buildlog_ubuntu-bionic-amd64.ubuntu-advantage-tools_30~18.04_BUILDING.txt.gz)

ubuntu-advantage-tools 30~20.04 was built with
pkgbinarymangler 144.20.04.0
(from build log https://launchpadlibrarian.net/697068151/buildlog_ubuntu-focal-amd64.ubuntu-advantage-tools_30~20.04_BUILDING.txt.gz)

ubuntu-advantage-tools 30~22.04 was built with
pkgbinarymangler 149.22.04.0
(from build log https://launchpadlibrarian.net/697068014/buildlog_ubuntu-jammy-amd64.ubuntu-advantage-tools_30~22.04_BUILDING.txt.gz)

ubuntu-advantage-tools 30~23.04 was built with
pkgbinarymangler 152.23.04.0
(from build log https://launchpadlibrarian.net/697067775/buildlog_ubuntu-lunar-amd64.ubuntu-advantage-tools_30~23.04_BUILDING.txt.gz)

- All the versions above are the -proposed version of the packages
- I used amd64 as the example but all build logs confirm those versions

I am thus marking this bug as verification-done.

** Tags removed: verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-lunar verification-needed-xenial
** Tags added: verification-done verification-done-bionic verification-done-focal verification-done-jammy verification-done-lunar verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pkgbinarymangler in Ubuntu.
https://bugs.launchpad.net/bugs/2037584

Title:
  ubuntu-pro-client-l10n translations are stripped

Status in pkgbinarymangler package in Ubuntu:
  Fix Released
Status in pkgbinarymangler source package in Xenial:
  Fix Committed
Status in pkgbinarymangler source package in Bionic:
  Fix Committed
Status in pkgbinarymangler source package in Focal:
  Fix Committed
Status in pkgbinarymangler source package in Jammy:
  Fix Committed
Status in pkgbinarymangler source package in Lunar:
  Fix Committed

Bug description:
  [ Impact ]

  In the upcoming version of ubuntu-advantage-tools, we will ship
  translation files in a new separate binary package called ubuntu-pro-
  client-l10n.

  If you build ubuntu-pro-client-l10n with the current version of
  pkgbinarymangler, then translations are stripped and tarballed for
  inclusion in the langpack. We specifically don't want these
  translations included in the langpack for any release because pro-
  client gets updates (including strings) more frequently and many more
  times than langpacks get built.

  In order to ship those translation files in ubuntu-pro-client-l10n we
  need to stop pkgbinarymangler from stripping them at build time.
  pkgbinarymangler has striptranslations.blacklist specifically for this
  purpose, so the fix is to add ubuntu-pro-client-l10n to that list.

  [ Test Plan ]

  Since the ubuntu-pro-client-l10n package is only getting introduced in
  the next version of ubuntu-advantage-tools (v30), the fixing and
  testing of this bug needs to be closely coordinated with the release
  of u-a-t.

  Once u-a-t v30 is fully reviewed and ready to move to -proposed, we
  will first upload the fix of this bug to -proposed and wait for the
  binary proposed publication of pkgbinarymangler to complete. Then we
  will accept u-a-t v30 to -proposed.

  In order to test that this bug is fixed, we will check that the binary
  ubuntu-pro-client-l10n package built from u-a-t v30 in -proposed
  contains the appropriate translation files. We will also verify that
  translations are working in u-a-t when ubuntu-pro-client-l10n is
  installed.

  After showing all of that working together, we can mark this bug as verification-done
     
  [ Where problems could occur ]

  striptranslations.blacklist is a list of regexes, so if `ubuntu-pro-
  client-l10n` accidentally matches some other package, then that
  package would not have its translations stripped either.

  Generally, new packages in -updates on ESM releases such as xenial and
  bionic (perhaps aside from u-a-t) are surprising and unexpected to
  users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pkgbinarymangler/+bug/2037584/+subscriptions