[Bug 2038087] Re: [FFe] flash-kernel displays wrong "selected" DTB on various Pi models

[Dave Jones]

** Description changed:

- flash-kernel probably shouldn't even be dealing with the DTBs on Pi but
- it's picking the wrong one for some machine models. For example on a
- Raspberry Pi 400 Rev 1.0 it uses bcm2711-rpi-4-b.dtb. Same one Compute
- Module 3 and 3+.
+ [ Impact ]
+ 
+ flash-kernel displays a "selected" DTB at the top of its output. On a Pi
+ this isn't actually that relevant as it goes on to copy every DTB
+ associated with the kernel anyway, but this is still confusing for
+ users, especially when they see a completely different board model than
+ the one they expected (e.g. at present on the Pi 400 or Pi 5, the output
+ will indicate that the rpi-4-b dtb is being used).
+ 
+ [ Test Plan ]
+ 
+ * Boot a mantic daily image on an affected model of Pi (400, 5, CM3, CM3+, Zero 2W)
+ * Run "sudo flash-kernel" and confirm it outputs "Using DTB: bcm2711-rpi-4-b.dtb" at the top of its messages
+ * Enable the -proposed pocket and "sudo apt update"
+ * "sudo apt install flash-kernel" to update flash-kernel to the proposed version
+ * Run "sudo flash-kernel" and confirm it outputs the correct DTB for the selected model of Pi.
+ 
+ [ Regression Potential ]
+ 
+ Low; the existing flash-kernel already copies all DTBs found and the
+ proposed one will too (all Pi related entries use "Method: pi", the
+ method isn't changing in its behaviour, the only db entries that are
+ changing are Pi related). Thus the worst-case scenario is that flash-
+ kernel continues to output the "wrong" DTB at the top of its output,
+ which is no worse than the present situation.
+ 
+ [ Original Description ]
+ flash-kernel probably shouldn't even be dealing with the DTBs on Pi but it's picking the wrong one for some machine models. For example on a Raspberry Pi 400 Rev 1.0 it uses bcm2711-rpi-4-b.dtb. Same one Compute Module 3 and 3+.
  
  It's probably because in /usr/share/flash-kernel/db/all.db the catch-all
  
  Machine: Raspberry Pi *
  
  is listed before these above mentioned models (and others as well).

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to flash-kernel in Ubuntu.
https://bugs.launchpad.net/bugs/2038087

Title:
  [FFe] flash-kernel displays wrong "selected" DTB on various Pi models

Status in flash-kernel package in Ubuntu:
  Confirmed

Bug description:
  [ Impact ]

  flash-kernel displays a "selected" DTB at the top of its output. On a
  Pi this isn't actually that relevant as it goes on to copy every DTB
  associated with the kernel anyway, but this is still confusing for
  users, especially when they see a completely different board model
  than the one they expected (e.g. at present on the Pi 400 or Pi 5, the
  output will indicate that the rpi-4-b dtb is being used).

  [ Test Plan ]

  * Boot a mantic daily image on an affected model of Pi (400, 5, CM3, CM3+, Zero 2W)
  * Run "sudo flash-kernel" and confirm it outputs "Using DTB: bcm2711-rpi-4-b.dtb" at the top of its messages
  * Enable the -proposed pocket and "sudo apt update"
  * "sudo apt install flash-kernel" to update flash-kernel to the proposed version
  * Run "sudo flash-kernel" and confirm it outputs the correct DTB for the selected model of Pi.

  [ Regression Potential ]

  Low; the existing flash-kernel already copies all DTBs found and the
  proposed one will too (all Pi related entries use "Method: pi", the
  method isn't changing in its behaviour, the only db entries that are
  changing are Pi related). Thus the worst-case scenario is that flash-
  kernel continues to output the "wrong" DTB at the top of its output,
  which is no worse than the present situation.

  [ Original Description ]
  flash-kernel probably shouldn't even be dealing with the DTBs on Pi but it's picking the wrong one for some machine models. For example on a Raspberry Pi 400 Rev 1.0 it uses bcm2711-rpi-4-b.dtb. Same one Compute Module 3 and 3+.

  It's probably because in /usr/share/flash-kernel/db/all.db the catch-
  all

  Machine: Raspberry Pi *

  is listed before these above mentioned models (and others as well).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/2038087/+subscriptions