[Bug 2037407] Re: [SRU] Add support for AMD-Xilinx Kria KD240

[Andreas Hasenack]

Sorry, I have no idea how this package works, so I can't review the code
changes properly, only the syntax of the patch.

This should be reviewed by someone familiar with u-boot, so I'm
subscribing Dave Jones to this bug, as he has uploaded this package
before.

devel_0.debdiff:
- d/changelog needs to be updated for noble (3.107ubuntu3, and noble release name) Maybe the whole patch could be rebased, as there is an offset in db/all.db
- there is no indication from where these changes are coming from. I know this is a native package, but if there is some upstream repository with PRs and comments about these changes, could they be linked somewhere perhaps? But this is just me asking as someone who is not familiar at all with this package.
- the d/changelog diff is also making changes elsewhere in the file, not just adding an entry on top. That is usually not desirable:
@@ -614,7 +620,7 @@

   * Add riscv64 support (LP: #1966219)
   * Add the following boards to db/all.db
-    - SiFive HiFive Unmatched A00 
+    - SiFive HiFive Unmatched A00
     - BeagleV Starlight Beta

  -- Heinrich Schuchardt <heinrich.schuchardt at canonical.com>  Tue, 08
Mar 2022 10:05:15 +0100


The other debdiffs also have that stray changelog change.

We will also need a mantic diff, now that noble is open for development
already.


You should update the [test case] with what you said in the [regression potential] section, about testing other affected boards.

** Also affects: flash-kernel (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Also affects: flash-kernel (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Also affects: flash-kernel (Ubuntu Mantic)
   Importance: Undecided
       Status: New

** Also affects: flash-kernel (Ubuntu Lunar)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to flash-kernel in Ubuntu.
https://bugs.launchpad.net/bugs/2037407

Title:
  [SRU] Add support for AMD-Xilinx Kria KD240

Status in flash-kernel package in Ubuntu:
  New
Status in flash-kernel source package in Jammy:
  New
Status in flash-kernel source package in Lunar:
  New
Status in flash-kernel source package in Mantic:
  New
Status in flash-kernel source package in Noble:
  New

Bug description:
  [Impact]

  Add AMD-Xilinx Kria KD240 board support

  [Where problems could occur]

  The patch adds support for the AMD-Xilinx Kria KD240, but affects the
  boot script used by:

  * ZCU 102, 104, 106, 111
  * Kria KR revisions A, B, 1
  * Kria KV revisions A, B, Z, 1

  [Test Case]

  * Enable proposed updates (https://wiki.ubuntu.com/Testing/EnableProposed)
  * Update flash-kernel to the version in -proposed: sudo apt install -t jammy-proposed flash-kernel
  * Run flash-kernel (if the upgrade didn't already): sudo flash-kernel
  * Reboot: sudo reboot
  * Ensure system boots successfully

  [Regression Potential]

  As the patch touches the u-boot script used by several boards (listed
  above), booting should be re-tested against the potentially affected
  boards under the proposed package.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/2037407/+subscriptions