[Bug 1999275] Re: systemd-binfmt.service fails in tests-in-lxd
Launchpad Bug Tracker
1999275 at bugs.launchpad.net
Tue Sep 12 23:33:37 UTC 2023
This bug was fixed in the package systemd - 249.11-0ubuntu3.10
---------------
systemd (249.11-0ubuntu3.10) jammy; urgency=medium
[ Nick Rosbrook ]
* debian/tests/tests-in-lxd: use --reuse flag in lxc publish (LP: #2023229)
File: debian/tests/tests-in-lxd
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=85b2ceddff1a6cc1ddbca8a1b7e5381d146e6313
* pstore: only try to load efi_pstore module (LP: #2023462)
File: debian/patches/lp1978079-efi-pstore-not-cleared-on-boot.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=7600bbfb1e8a399e5aeb1010a20deda3e5a06c89
* shutdown: get only active md arrays. (LP: #2025563)
File: debian/patches/lp2025563-shutdown-get-only-active-md-arrays.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=416a9245c8f0efbedcc4395cada23cb09c685ec3
* udev-rules: fix nvme symlink creation on namespace changes (LP: #2028180)
File: debian/patches/lp2028180-udev-rules-fix-nvme-symlink-creation-on-namespace-changes.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=26e85b944da9098e66fc0c39f64ee40254c0c278
* core: reorder systemd arguments on reexec (LP: #2013543)
File: debian/patches/lp2013543-core-reorder-systemd-arguments-on-reexec.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=19ba0f20d311642596dc65fa5d6eb96a2d4be280
* network/dhcp4: do not ignore the gateway even if the destination is in same network (LP: #2009743)
Files:
- debian/patches/lp2009743/network-dhcp4-do-not-ignore-the-gateway-even-if-the-desti.patch
- debian/patches/lp2009743/test-network-add-one-more-testcase-for-DHCPv4-classless-r.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=73e774a2fb99c82df6d0edd770bb84ab735ec2f0
* Drop debian/UBUNTU-wait-online-exit-if-no-links-are-managed.patch (LP: #1982218)
File: debian/patches/debian/UBUNTU-wait-online-exit-if-no-links-are-managed.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=cf82f08feea456e1c65895b34bffa8c33d421588
* debian/systemd.postint: do not daemon re-exec if we could hit LP: #2013543
File: debian/systemd.postinst
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=be484dab06d590b1792a8f016f4292373d0174b7
* binfmt: fix systemd-binfmt in LXD containers (LP: #1999275)
Files:
- debian/patches/lp1999275/binfmt-check-if-binfmt-is-mounted-before-applying-rules.patch
- debian/patches/lp1999275/binfmt-util-also-check-if-binfmt-is-mounted-in-read-write.patch
- debian/patches/lp1999275/binfmt-util-split-out-binfmt_mounted.patch
- debian/patches/lp1999275/unit-check-more-specific-path-to-be-written-by-systemd-bi.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=0b9eadf05ee6db0e009dacbc71521480095880b3
[ Dan Streetman ]
* Fix machinectl pull-tar and import-tar (LP: #1977630)
Author: Dan Streetman
File: debian/patches/lp1977630-fix_machinectl_pull_tar.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=1e7d3febe1600c6eb03bd71a17be6a6af52988c7
* make machinectl read-only work (LP: #1991829)
Author: Dan Streetman
File: debian/patches/lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=7a7c47569e0a2d175915eb0b79c60f2611848731
-- Nick Rosbrook <enr0n at ubuntu.com> Mon, 21 Aug 2023 17:11:40 -0400
** Changed in: systemd (Ubuntu Jammy)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1999275
Title:
systemd-binfmt.service fails in tests-in-lxd
Status in systemd package in Ubuntu:
Fix Released
Status in systemd source package in Jammy:
Fix Released
Bug description:
[Impact]
systemd-binfmt.service fails in LXD because access
/proc/sys/binfmt_misc is prevented by LXD apparmor config. This causes
our autopkgtest to fail, and leaves systemd-binfmt.service in a failed
state:
root at jammy:~# systemctl status systemd-binfmt
× systemd-binfmt.service - Set Up Additional Binary Formats
Loaded: loaded (/lib/systemd/system/systemd-binfmt.service; static)
Active: failed (Result: exit-code) since Thu 2023-08-17 18:54:18 UTC; 1min 12s ago
Docs: man:systemd-binfmt.service(8)
man:binfmt.d(5)
https://www.kernel.org/doc/html/latest/admin-guide/binfmt-misc.html
https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems
Main PID: 118 (code=exited, status=1/FAILURE)
CPU: 5ms
Aug 17 18:54:18 jammy systemd[1]: Starting Set Up Additional Binary Formats...
Aug 17 18:54:18 jammy systemd-binfmt[118]: Failed to add binary format: Permission denied
Aug 17 18:54:18 jammy systemd[1]: systemd-binfmt.service: Main process exited, code=exited, status=1/FAILURE
Aug 17 18:54:18 jammy systemd[1]: systemd-binfmt.service: Failed with result 'exit-code'.
Aug 17 18:54:18 jammy systemd[1]: Failed to start Set Up Additional Binary Formats.
[Test Plan]
1. test_no_failed from boot-and-services should pass.
2. Manual test:
* Start a Jammy LXD container:
$ lxc launch ubuntu-daily:jammy jammy
$ lxc exec jammy bash
* In the container, check systemd-binfmt.service:
root at jammy:~# systemctl status systemd-binfmt
● systemd-binfmt.service - Set Up Additional Binary Formats
Loaded: loaded (/lib/systemd/system/systemd-binfmt.service; static)
Drop-In: /etc/systemd/system/systemd-binfmt.service.d
└─override.conf
Active: active (exited) since Thu 2023-08-17 19:01:00 UTC; 2min 27s ago
Docs: man:systemd-binfmt.service(8)
man:binfmt.d(5)
https://www.kernel.org/doc/html/latest/admin-guide/binfmt-misc.html
https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems
Main PID: 122 (code=exited, status=0/SUCCESS)
CPU: 5ms
Aug 17 19:01:00 jammy systemd[1]: Starting Set Up Additional Binary Formats...
Aug 17 19:01:00 jammy systemd[1]: Finished Set Up Additional Binary Formats.
root at jammy:~# journalctl -t systemd-binfmt -b
Aug 17 19:01:00 jammy systemd-binfmt[122]: /proc/sys/fs/binfmt_misc is not mounted in read-write mode, skipping.
[ Where problems could occur]
The patches are contained to binfmt logic in systemd, and so any
regressions would be within systemd-binfmt itself. The patches make it
so that systemd-binfmt checks if /proc/sys/binfmt_misc is mounted as
rw before trying to make any changes. If it is mounted, but read-only,
then systemd-binfmt will exit cleanly and log a message indicating so.
If the patch was incorrect, it could make it so that systemd-binfmt is
not fully executed on systems where it should be.
[Original Description]
The systemd-binfmt.service requires read-write access to
/proc/sys/fs/binfmt_misc, but this is not possible in unprivileged LXD
containers without binfmt_misc namespace support in the kernel [1].
When this service is triggered, we get the following failure from
test_no_failed within tests-in-lxd:
No failed units ... -------- journal for failed service systemd-binfmt.service -----------
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd[1]: Starting Set Up Additional Binary Formats...
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd-binfmt[99]: Failed to flush binfmt_misc rules, ignoring: Permission denied
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd-binfmt[99]: /usr/lib/binfmt.d/python3.10.conf:1: Failed to delete rule 'python3.10', ignoring: Permission denied
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd-binfmt[99]: /usr/lib/binfmt.d/python3.10.conf:1: Failed to add binary format 'python3.10': Permission denied
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd[1]: systemd-binfmt.service: Main process exited, code=exited, status=1/FAILURE
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd[1]: systemd-binfmt.service: Failed with result 'exit-code'.
Dec 08 10:43:37 autopkgtest-lxd-qicaxl systemd[1]: Failed to start Set Up Additional Binary Formats.
FAIL
test_rsyslog (__main__.ServicesTest) ... ok
test_tmp_cleanup (__main__.ServicesTest) ... ok
test_tmp_mount (__main__.ServicesTest) ... ok
test_udev (__main__.ServicesTest) ... skipped 'udev does not work in containers'
======================================================================
FAIL: test_no_failed (__main__.ServicesTest)
No failed units
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.METFVA/build.LjB/real-tree/debian/tests/boot-and-services", line 74, in test_no_failed
self.assertEqual(failed, [])
AssertionError: Lists differ: ['systemd-binfmt.service loaded failed failed Set Up Additional Binary Formats'] != []
First list contains 1 additional elements.
First extra element 0:
'systemd-binfmt.service loaded failed failed Set Up Additional Binary Formats'
- ['systemd-binfmt.service loaded failed failed Set Up Additional Binary Formats']
+ []
The systemd-binfmt.service is only started if there is a configuration
to be loaded from one of the valid configuration directories (e.g.
/usr/lib/binfmt.d/python3.10.conf). Previously, no such file was
installed in the test LXD images, but a recent upload of python3.10
added support for systemd-binfmt [2].
[1] https://discuss.linuxcontainers.org/t/3-1-0-binfmt-support-service-in-unprivileged-guest-requires-write-access-on-hosts-proc-sys-fs-binfmt-misc/5249
[2] https://launchpadlibrarian.net/632281245/python3.10_3.10.8-1_3.10.8-3.diff.gz
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1999275/+subscriptions
More information about the foundations-bugs
mailing list