[Bug 2035616] Re: Enable swap partitions in nvme disks

[Alkis Georgopoulos]

*** This bug is a duplicate of bug 2023605 ***
    https://bugs.launchpad.net/bugs/2023605

> this patch returns bogus strings in the case that there are no devices
matching

This was already the case, e.g. with no disk at all, it would return `/dev/[hsv]d[a-z][0-9]*`.
And that's fine as it would be ignored by the following if:

if ! [ -b "$device" ]; then
   continue

Personally I don't think that looping over all of /dev is more robust, but it's up to the authors.
Thanks for marking as duplicate, I didn't manage to locate your issue while submitting.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to casper in Ubuntu.
https://bugs.launchpad.net/bugs/2035616

Title:
  Enable swap partitions in nvme disks

Status in casper package in Ubuntu:
  New

Bug description:
  Hi, the code that automatically enables swap partitions, currently
  doesn't match nvme disks:

  https://git.launchpad.net/casper/tree/scripts/casper-bottom/13swap#n30

  It should be modified to:

  for device in /dev/[hsv]d[a-z][0-9]* /dev/nvme[0-9]n[0-9]p[0-9]*; do

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/casper/+bug/2035616/+subscriptions