[Bug 2060708] [NEW] hfsutils: FTBFS: hpwd.c:55:7: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]

[Benjamin Drung]

Public bug reported:

Imported from Debian bug http://bugs.debian.org/1066216:

Source: hfsutils
Version: 3.2.6-15
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Ilibhfs -I/usr/include/tcl -I/usr/include/tk  -DHAVE_CONFIG_H -DUSE_INTERP_RESULT   -c -o hpwd.o hpwd.c
> hpwd.c: In function ‘hpwd_main’:
> hpwd.c:55:7: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]
>    55 |   if (strcmp(ent->cwd, ":") == 0)
>       |       ^~~~~~
> hpwd.c:32:1: note: include ‘<string.h>’ or provide a declaration of ‘strcmp’
>    31 | # include "hpwd.h"
>   +++ |+#include <string.h>
>    32 | 
> cc1: some warnings being treated as errors
> make[1]: *** [<builtin>: hpwd.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/hfsutils_3.2.6-15_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

** Affects: hfsutils (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: hfsutils (Debian)
     Importance: Undecided
         Status: New


** Tags: update-excuse

** Bug watch added: Debian Bug tracker #1066216
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066216

** Changed in: hfsutils (Debian)
 Remote watch: None => Debian Bug tracker #1066216

** Tags added: update-excuse

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to hfsutils in Ubuntu.
https://bugs.launchpad.net/bugs/2060708

Title:
  hfsutils: FTBFS: hpwd.c:55:7: error: implicit declaration of function
  ‘strcmp’ [-Werror=implicit-function-declaration]

Status in hfsutils package in Ubuntu:
  New
Status in hfsutils package in Debian:
  New

Bug description:
  Imported from Debian bug http://bugs.debian.org/1066216:

  Source: hfsutils
  Version: 3.2.6-15
  Severity: serious
  Justification: FTBFS
  Tags: trixie sid ftbfs
  User: lucas at debian.org
  Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

  Hi,

  During a rebuild of all packages in sid, your package failed to build
  on amd64.

  This is most likely caused by a change in dpkg 1.22.6, that enabled
  -Werror=implicit-function-declaration. For more information, see
  https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

  Relevant part (hopefully):
  > gcc -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Ilibhfs -I/usr/include/tcl -I/usr/include/tk  -DHAVE_CONFIG_H -DUSE_INTERP_RESULT   -c -o hpwd.o hpwd.c
  > hpwd.c: In function ‘hpwd_main’:
  > hpwd.c:55:7: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]
  >    55 |   if (strcmp(ent->cwd, ":") == 0)
  >       |       ^~~~~~
  > hpwd.c:32:1: note: include ‘<string.h>’ or provide a declaration of ‘strcmp’
  >    31 | # include "hpwd.h"
  >   +++ |+#include <string.h>
  >    32 | 
  > cc1: some warnings being treated as errors
  > make[1]: *** [<builtin>: hpwd.o] Error 1

  
  The full build log is available from:
  http://qa-logs.debian.net/2024/03/13/hfsutils_3.2.6-15_unstable.log

  All bugs filed during this archive rebuild are listed at:
  https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
  or:
  https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

  A list of current common problems and possible solutions is available at
  http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

  If you reassign this bug to another package, please mark it as 'affects'-ing
  this package. See https://www.debian.org/Bugs/server-control#affects

  If you fail to reproduce this, please provide a build log and diff it with mine
  so that we can identify if something relevant changed in the meantime.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/hfsutils/+bug/2060708/+subscriptions