[Bug 2069360] Re: apport-autoreport.service fails if autoreporting is disabled

[Chris Peterson]

Looks good to me. Booted noble release ISO and followed the steps as
described.

Changed "send error reports to canonical" from "manual" to "never".

Produced a crash with `divide-by-zero` from chaos-marmosets. Apport
prompt came up but only with a "continue" button. No crash report
uploaded.

Before upgrade:

$ systemctl status apport-autoreport.service
○ apport-autoreport.service - Process error reports when automatic reporting is enabled
     Loaded: loaded (/usr/lib/systemd/system/apport-autoreport.service; static)
     Active: inactive (dead)
TriggeredBy: ○ apport-autoreport.path
             ○ apport-autoreport.timer


After upgrade:

$ systemctl status apport-autoreport.service
○ apport-autoreport.service - Process error reports when automatic reporting is enabled
     Loaded: loaded (/usr/lib/systemd/system/apport-autoreport.service; static)
     Active: inactive (dead)
TriggeredBy: ○ apport-autoreport.timer
             ○ apport-autoreport.path
  Condition: start condition unmet at Wed 2024-08-07 23:43:41 UTC; 13s ago
             └─ ConditionPathExists=/var/lib/apport/autoreport was not met

Aug 07 23:43:41 ubuntu systemd[1]: apport-autoreport.service - Process
error reports when automatic reporting is enabled was skipped because of
an unmet condition check
(ConditionPathExists=/var/lib/apport/autoreport).

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/2069360

Title:
  apport-autoreport.service fails if autoreporting is disabled

Status in Apport:
  Fix Committed
Status in apport package in Ubuntu:
  Fix Committed
Status in apport source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  apport-autoreport.service fails if auto-reporting is disabled:

  ```
  $ systemctl status apport-autoreport.service
  × apport-autoreport.service - Process error reports when automatic reporting is enabled
       Loaded: loaded (/usr/lib/systemd/system/apport-autoreport.service; static)
       Active: failed (Result: exit-code) since Thu 2024-06-13 21:55:08 CEST; 1h 9min ago
  TriggeredBy: ● apport-autoreport.timer
               ● apport-autoreport.path
      Process: 1059564 ExecStart=/usr/share/apport/whoopsie-upload-all --timeout 20 (code=exited, status=1/FAILURE)
     Main PID: 1059564 (code=exited, status=1/FAILURE)
          CPU: 86ms

  Jun 13 21:55:08 host systemd[1]: Starting apport-autoreport.service - Process error reports when automatic reporting is enabled...
  Jun 13 21:55:08 host whoopsie-upload-all[1059564]: ERROR: whoopsie.path is not enabled
  Jun 13 21:55:08 host systemd[1]: apport-autoreport.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 21:55:08 host systemd[1]: apport-autoreport.service: Failed with result 'exit-code'.
  Jun 13 21:55:08 host systemd[1]: Failed to start apport-autoreport.service - Process error reports when automatic reporting is enabled.
  ```

  This service failure might mislead user thinking that there is a
  problem.

  [ Test Plan ]

  1. Disable auto-reporting in the system setting:
    * open gnome-control-center or unity-control-center
    * Switch to "Security & Privacy" panel
    * Select "Diagnosticts" tab
    * unselect "Send error reports to Canonical"
  2. Produce a crash, e.g. by running divide-by-zero from chaos-marmosets
  3. Check that apport-autoreport.service is failing as above
  4. Upgrade Apport to the fixed version
  5. Restart apport-autoreport.service
  6. apport-autoreport.service should exit successfully

  [ Where problems could occur ]

  This code change touches the auto-reporting part. Failures there could
  lead to less bugs being forwarded to the error tracker. This might be
  noticeable when looking at the number of submissions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/2069360/+subscriptions