[Bug 2076233] Re: AttributeError: 'Report' object has no attribute 'add_tags'

[Olivier Gayot]

After investigating more (see below for details), I confirm that noble
is _not_ currently affected. Only the development version of Subiquity
(i.e., oracular) is.

When Subiquity creates a crash report, we expect apport to execute hooks
from /snap/subiquity/current/usr/share/apport/general-hooks ; not
/usr/share/apport/general-hooks/

Apport reads the APPORT_DATA_DIR variable to determine where to find the
hooks and Subiquity sets it. However, the variable is read as soon as
`import apport` is run ; whereas Subiquity sets the variable in the
`setup_environment()` function.

On oracular, because of some refactoring (possibly to add some type
hints), the `apport` module gets loaded _before_ the
`setup_environment()` function gets called. Therefore, Apport sets the
hooks directory as /usr/share/apport/general-hooks.

Here's a chunk that shows the difference between Oracular and Noble (run
it with `make dryrun-server`).

https://paste.ubuntu.com/p/BWFqNwnRVr/

** Changed in: subiquity (Ubuntu)
     Assignee: (unassigned) => Olivier Gayot (ogayot)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2076233

Title:
  AttributeError: 'Report' object has no attribute 'add_tags'

Status in subiquity package in Ubuntu:
  Triaged

Bug description:
  When testing things on oracular, I ran into this exception after a
  late-commands failed:

  ERROR: hook /usr/share/apport/general-hooks/ubuntu.py crashed
  Traceback (most recent call last):
    File "/snap/subiquity/5988/usr/lib/python3/lib/python3/dist-packages/apport/report.py", line 228, in _run_hook
      symb['add_info'](report, ui)
    File "/usr/share/apport/general-hook/ubuntu.py", line 34, in add_info
      _add_release_info(report)
    File "/usr/share/apport/general-hooks/ubuntu.py", line 472, in _add_release_info
      report.add_tags([release_codename])
  AttributeError: 'Report' object has no attribute 'add_tags'.

  This seems to happen because the Report class in core22
  (/snap/subiquity/.../report.py) does not define an add_tags method ;
  but the hooks in oracular expect the method to exist.

  This might not be limited to oracular ; and could be a thing in noble
  too?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/2076233/+subscriptions