[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled

[Julian Andres Klode]

** Description changed:

  [Impact]
  If you have Source Code enabled, and you change the pockets configuration to "all pockets", it will add -backports without source code. The Source Code flag will still be set in the UI, but after a reload, you can see it is in a mixed state.
  
  This is more notable now, because this splits up the deb822 paragraph
  into two: One for the deb, and one for deb-src, whereas it should remain
  one.
  
  [Test plan]
  1. Turn on source code, save and refresh sources, close app
- 2. Turn "recommended updates" to "all updates", observe that -backports got added with deb-src, to the existing paragraph.
+ 2. Start again, observe the flag is on.
+ 3. Turn "recommended updates" to "all updates", observe that -backports got added with deb-src, to the existing paragraph.
+ 4. Restart the app and observe that the flag is still on.
  
  [Where problems could occur]
  This incurs a performance regression, as we need to check the state of the source code flag after reloading sources. That said, this is of course necessary for the source code flag to be correct after reloading modified sources (it gets reset to False when reloading). And since we run in a dbus service, we may just be reloading without having made the changes ourselves, so we can't just cache the old value and restore it.
  
  That said, software-properties already times out on my oracular system.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/2069433

Title:
  Enabling new pockets does not enable deb-src for them, even if source
  code is enabled

Status in software-properties package in Ubuntu:
  Fix Released
Status in software-properties source package in Noble:
  Fix Committed

Bug description:
  [Impact]
  If you have Source Code enabled, and you change the pockets configuration to "all pockets", it will add -backports without source code. The Source Code flag will still be set in the UI, but after a reload, you can see it is in a mixed state.

  This is more notable now, because this splits up the deb822 paragraph
  into two: One for the deb, and one for deb-src, whereas it should
  remain one.

  [Test plan]
  1. Turn on source code, save and refresh sources, close app
  2. Start again, observe the flag is on.
  3. Turn "recommended updates" to "all updates", observe that -backports got added with deb-src, to the existing paragraph.
  4. Restart the app and observe that the flag is still on.

  [Where problems could occur]
  This incurs a performance regression, as we need to check the state of the source code flag after reloading sources. That said, this is of course necessary for the source code flag to be correct after reloading modified sources (it gets reset to False when reloading). And since we run in a dbus service, we may just be reloading without having made the changes ourselves, so we can't just cache the old value and restore it.

  That said, software-properties already times out on my oracular
  system.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions