[Bug 2076913] Re: 'DistUpgradeController' object has no attribute 'force_obsoletes'

[Łukasz Zemczak]

Hello Tobias, or anyone else affected,

Accepted ubuntu-release-upgrader into noble-proposed. The package will
build now and be available at
https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:24.04.22
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-release-upgrader (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/2076913

Title:
  'DistUpgradeController' object has no attribute 'force_obsoletes'

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Noble:
  Fix Committed

Bug description:
  [Impact]

  It looks like the latest SRU has introduced a bug in
  https://git.launchpad.net/ubuntu-release-
  upgrader/commit/?id=8c592abdf5047a6bd4da20dab1e444c6dcf8c842

  There is a typo in s/force_obosoletes/forced_obsoletes/ which causes upgrades from noble to oracular to
  fail:

    File "/tmp/ubuntu-release-upgrader-l77uthwp/DistUpgrade/DistUpgradeController.py", line 1578, in doPostUpgrade
      if pkgname in self.foreign_pkgs and pkgname in self.force_obsoletes:
                                                     ^^^^^^^^^^^^^^^^^^^^
  AttributeError: 'DistUpgradeController' object has no attribute 'force_obsoletes'. Did you mean: 'forced_obsoletes'?

  [Test Plan]

  This code path is only hit when some "foreign" packages are installed,
  e.g. from a PPA. The best way to reproduce this is to install a
  package from a PPA and then perform an upgrade. I created
  https://launchpad.net/~enr0n/+archive/ubuntu/lp2076913 for convenience
  in testing.

  $ apt-add-repository -y ppa:enr0n/https://launchpad.net/~enr0n/+archive/ubuntu/lp2076913
  $ apt install -y hello
  $ do-release-upgrade -d

  On an affected system, the AttributeError would be shown during the
  searching for obsoletes stage. One should confirm that some "foreign"
  packages were logged, otherwise the code path would not be taken:

  $ grep "Foreign" /var/log/dist-upgrade/main.log

  [Where problems could occur]

  The patch changes the typo self.force_obsoletes to the correct
  self.forced_obsoletes. Another typo would lead to the same problem!

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/2076913/+subscriptions