[Bug 2076309] Re: [SRU] xfsprogs missing frame pointer

[Andreas Hasenack]

Something else that I find troublesome is that the test plan is only
focused on the change being introduced in this SRU, namely, the new
build flags. And in a passive way: just check if the resulting binary
has some attribute, and if the build logs have a certain flag.

This is missing an actual check to see if xfsprogs is still working
correctly. There are no DEP8 tests to at least perform a simple smoke
test. I think this needs improving.

We should at the very least test basic functionality, like creating and
checking filesystems, resize (grow), etc. It would be very bad if this
update triggered an assertion error in one of these functions due to the
new FORTIFY_SOURCE=3 flag, for example.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to xfsprogs in Ubuntu.
https://bugs.launchpad.net/bugs/2076309

Title:
  [SRU] xfsprogs missing frame pointer

Status in xfsprogs package in Ubuntu:
  Fix Released
Status in xfsprogs source package in Noble:
  Incomplete
Status in xfsprogs source package in Oracular:
  Fix Released

Bug description:
  xfsprogs missing frame pointer despite the build flags already contain
  compiler flags to enable frame pointers.

  [Impact]

  In order to help developers with profiling, Ubuntu enabled frame-
  pointers for packages in the main archive.

  https://ubuntu.com/blog/ubuntu-performance-engineering-with-frame-
  pointers-by-default

  The `Affects` packages were missed due to the packaging issues. These
  have been fixed on Oracular and can now be ported to Noble.

  [Test Plan]

  Look at the DW_AT_producer in the associated debug ELF file for flags.
  -fno-omit-frame-pointer should be present after the fix.

  The following scripts can be used as a reference
  https://gist.github.com/julian-klode/85e55553f85c410a1b856a93dce77208
  https://gist.github.com/julian-klode/95818246eaef0ac6a54588f7f368e25c

  You can also check the build logs for build flags like `-fno-omit-
  frame-pointer`.

  [Where problems could occur]

  * A distribution-specific patch was applied to fix the build with security hardening flags enabled.
  * The packaging fixes have enabled other security hardening flags. This could have unintended effects.

  [Other Info]

  changes in dpkg have been made to make sure frame-pointers are not
  enabled on s390x and ppc64el.

  Bug reference with similar SRU -
  https://bugs.launchpad.net/ubuntu/+source/ipvsadm/+bug/2071949

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xfsprogs/+bug/2076309/+subscriptions