[Bug 2080608] Re: [SRU] storage.layout.mode="use_gap" does not honor match directive

[Olivier Gayot]

** Description changed:

+ [ Impact ]
+ 
+ * when using Subiquity's autoinstall feature, once can use "match"
+ directives at the storage->layout level to find the right drive.
+ However, the match directives where silently ignored when using mode:
+ use_gap.
+ 
+ * This makes it difficult for the OEM team to install to the
+ installation media.
+ 
+ [ Test Plan ]
+ 
+ TBD
+ 
+ [ Where problems could occur ]
+ 
+ TBD
+ 
+ [ Other info ]
+ 
+ The change to merge is https://github.com/canonical/subiquity/pull/2083
+ 
+ [ Original description ]
+ 
  We found a problem that the following autoinstall config:
  
-   storage:
-     layout:
-       name: direct
-       mode: use_gap
-       match:
-         install-media: true
+   storage:
+     layout:
+       name: direct
+       mode: use_gap
+       match:
+         install-media: true
  
  does not actually match install-media, because use_gap does not use match directive to filter disks before finding a largest gap, according to the code in the below link:
  https://github.com/canonical/subiquity/blob/6727905effc4abc2d96c96986600efe392e3b7b6/subiquity/server/controllers/filesystem.py#L1614
  
  Internal reference: NANTOU-470

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to subiquity in Ubuntu.
https://bugs.launchpad.net/bugs/2080608

Title:
  [SRU] storage.layout.mode="use_gap" does not honor match directive

Status in subiquity:
  Fix Committed
Status in subiquity package in Ubuntu:
  New
Status in subiquity source package in Noble:
  New

Bug description:
  [ Impact ]

  * when using Subiquity's autoinstall feature, once can use "match"
  directives at the storage->layout level to find the right drive.
  However, the match directives where silently ignored when using mode:
  use_gap.

  * This makes it difficult for the OEM team to install to the
  installation media.

  [ Test Plan ]

  TBD

  [ Where problems could occur ]

  TBD

  [ Other info ]

  The change to merge is
  https://github.com/canonical/subiquity/pull/2083

  [ Original description ]

  We found a problem that the following autoinstall config:

    storage:
      layout:
        name: direct
        mode: use_gap
        match:
          install-media: true

  does not actually match install-media, because use_gap does not use match directive to filter disks before finding a largest gap, according to the code in the below link:
  https://github.com/canonical/subiquity/blob/6727905effc4abc2d96c96986600efe392e3b7b6/subiquity/server/controllers/filesystem.py#L1614

  Internal reference: NANTOU-470

To manage notifications about this bug go to:
https://bugs.launchpad.net/subiquity/+bug/2080608/+subscriptions