[Bug 2051952] Please test proposed package

[Robie Basak]

Hello Marc, or anyone else affected,

Accepted unzip into focal-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/unzip/6.0-25ubuntu1.2
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unzip in Ubuntu.
https://bugs.launchpad.net/bugs/2051952

Title:
  unzip rejects Microsoft OneDrive zip files

Status in unzip package in Ubuntu:
  Fix Released
Status in unzip source package in Focal:
  Fix Committed
Status in unzip source package in Jammy:
  Fix Committed
Status in unzip source package in Mantic:
  Fix Committed
Status in unzip source package in Noble:
  Fix Released

Bug description:
  [Impact]
  unzip rejects Microsoft OneDrive zip files. See the detailed explanation here:

  https://www.bitsgalore.org/2020/03/11/does-microsoft-onedrive-export-
  large-ZIP-files-that-are-corrupt

  tl;dr;
  Microsoft mishandles the "Total number of disks" field when using the ZIP64 extension. It should start at 1, they use 0, which isn't a valid value. Unzip doesn't properly handle the invalid value.

  [Test Plan]
  - Download the test zip file from comment #1.
  - unzip should extract it without issue (it contains a test.txt text file)
  - if unzip fails, it will spew out a weird error message like the following:

  $ unzip test.zip
  Archive:  test.zip
  error [test.zip]:  missing 4294967098 bytes in zipfile
    (attempting to process anyway)
  error [test.zip]:  start of central directory not found;
    zipfile corrupt.
    (please check that you have transferred or created the zipfile in the
    appropriate BINARY mode and that you have compiled UnZip properly)

  [Where problems could occur]
  This simple patch just accepts 0 as a valid total number of disks. I suppose if it was wrong it would mishandle multi-disk archives, though multi-disk archives should have a good value in that field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/2051952/+subscriptions