[Bug 2051952] Re: unzip rejects Microsoft OneDrive zip files

[Marc Deslauriers]

The autopkgtest failures in comments #10 and #11 have been retried and
have now passed.

I have tested (6.0-25ubuntu1.2) on focal, (6.0-26ubuntu3.2) on jammy and
(6.0-28ubuntu1.1) on mantic per the test procedure above, and all 3 of
them successfully extracted the test zip file after updating.

** Tags removed: verification-needed verification-needed-focal verification-needed-jammy verification-needed-mantic
** Tags added: verification-done verification-done-focal verification-done-jammy verification-done-mantic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unzip in Ubuntu.
https://bugs.launchpad.net/bugs/2051952

Title:
  unzip rejects Microsoft OneDrive zip files

Status in unzip package in Ubuntu:
  Fix Released
Status in unzip source package in Focal:
  Fix Committed
Status in unzip source package in Jammy:
  Fix Committed
Status in unzip source package in Mantic:
  Fix Committed
Status in unzip source package in Noble:
  Fix Released

Bug description:
  [Impact]
  unzip rejects Microsoft OneDrive zip files. See the detailed explanation here:

  https://www.bitsgalore.org/2020/03/11/does-microsoft-onedrive-export-
  large-ZIP-files-that-are-corrupt

  tl;dr;
  Microsoft mishandles the "Total number of disks" field when using the ZIP64 extension. It should start at 1, they use 0, which isn't a valid value. Unzip doesn't properly handle the invalid value.

  [Test Plan]
  - Download the test zip file from comment #1.
  - unzip should extract it without issue (it contains a test.txt text file)
  - if unzip fails, it will spew out a weird error message like the following:

  $ unzip test.zip
  Archive:  test.zip
  error [test.zip]:  missing 4294967098 bytes in zipfile
    (attempting to process anyway)
  error [test.zip]:  start of central directory not found;
    zipfile corrupt.
    (please check that you have transferred or created the zipfile in the
    appropriate BINARY mode and that you have compiled UnZip properly)

  [Where problems could occur]
  This simple patch just accepts 0 as a valid total number of disks. I suppose if it was wrong it would mishandle multi-disk archives, though multi-disk archives should have a good value in that field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/2051952/+subscriptions