[Bug 2055453] Re: FTBFS with -Werror=implicit-function-declaration

[Dan Bungert]

** Description changed:

  As part of time_t work, -Werror=implicit-function-declaration is being
- set, but that causes the following FTBFS:
+ set on armhf, but that causes the following FTBFS on any arch with the
+ same -Werror=implicit-function-declaration setting:
  
  https://launchpadlibrarian.net/716768885/buildlog_ubuntu-noble-
  armhf.pam_1.5.3-5ubuntu1_BUILDING.txt.gz
  
  In file included from obscure.c:42:
  obscure.c: In function ‘password_check’:
  support.h:160:9: error: implicit declaration of function ‘pam_overwrite_string’; did you mean ‘_pam_overwrite_n’? [-Werror=implicit-function-declaration]
-   160 |         pam_overwrite_string(xx);       \
-       |         ^~~~~~~~~~~~~~~~~~~~
+   160 |         pam_overwrite_string(xx);       \
+       |         ^~~~~~~~~~~~~~~~~~~~
  obscure.c:151:9: note: in expansion of macro ‘_pam_delete’
-   151 |         _pam_delete(newmono);
-       |         ^~~~~~~~~~~
+   151 |         _pam_delete(newmono);
+       |         ^~~~~~~~~~~

** Changed in: pam (Ubuntu)
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pam in Ubuntu.
https://bugs.launchpad.net/bugs/2055453

Title:
  FTBFS with -Werror=implicit-function-declaration

Status in pam package in Ubuntu:
  Fix Committed

Bug description:
  As part of time_t work, -Werror=implicit-function-declaration is being
  set on armhf, but that causes the following FTBFS on any arch with the
  same -Werror=implicit-function-declaration setting:

  https://launchpadlibrarian.net/716768885/buildlog_ubuntu-noble-
  armhf.pam_1.5.3-5ubuntu1_BUILDING.txt.gz

  In file included from obscure.c:42:
  obscure.c: In function ‘password_check’:
  support.h:160:9: error: implicit declaration of function ‘pam_overwrite_string’; did you mean ‘_pam_overwrite_n’? [-Werror=implicit-function-declaration]
    160 |         pam_overwrite_string(xx);       \
        |         ^~~~~~~~~~~~~~~~~~~~
  obscure.c:151:9: note: in expansion of macro ‘_pam_delete’
    151 |         _pam_delete(newmono);
        |         ^~~~~~~~~~~

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pam/+bug/2055453/+subscriptions