[Bug 2068809] Re: changelogs not listed for PPA packages

[Sebastien Bacher]

** Description changed:

+ * Impact
+ 
  When clicking on a package from a PPA in update-manager, the "Changes
  for XXX versions:" section will say:
  
  "This update does not come from a source that supports changelogs."
  
- and on the console it dumps:
+ Which seems a side effect of https://blog.launchpad.net/ppa/new-domain-
+ names-for-ppas , the code filter on ppa.launchpad.net in the url where
+ those are using ppa.launchpadcontent.net now
  
- ERROR:root:Unable to find a valid PPA candidate URL.
+ * Test case
  
+ - enable a ppa including an update for a package you have installed
+ - start update-manager and select that package
+ - check the long description at the bottom
+  
+ it should display the changelog entry for the update
  
- The reason is that in _extract_ppa_changelog_uri() in /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py it checks only for ppa.launchpad.net but nowadays the URI will contain ppa.launchpadcontent.net instead.
+ * Regression potential
  
+ The change is in the _extract_ppa_changelog_uri() function so a
+ potential issue would impact updates coming from a ppa. Verify that
+ those are correctly listed and include a valid description
+ 
+ -----------------------------------------------
+ 
+ The reason is that in _extract_ppa_changelog_uri() in
+ /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py it checks
+ only for ppa.launchpad.net but nowadays the URI will contain
+ ppa.launchpadcontent.net instead.
  
  With the below patch it will correctly display the changelogs:
  
  --- /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py.orig	2024-04-16 11:56:33.000000000 +0200
  +++ /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py	2024-06-08 20:33:51.462435498 +0200
  @@ -338,7 +338,7 @@ class MyCache(DistUpgrade.DistUpgradeCac
-  
-          cdt = self[name].candidate
-          for uri in cdt.uris:
+ 
+          cdt = self[name].candidate
+          for uri in cdt.uris:
  -            if urlsplit(uri).hostname != "ppa.launchpad.net":
  +            if urlsplit(uri).hostname not in ("ppa.launchpad.net", "ppa.launchpadcontent.net"):
-                  continue
-              match = re.search("http.*/(.*)/(.*)/ubuntu/.*", uri)
-              if match is not None:
+                  continue
+              match = re.search("http.*/(.*)/(.*)/ubuntu/.*", uri)
+              if match is not None:

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/2068809

Title:
  changelogs not listed for PPA packages

Status in update-manager package in Ubuntu:
  Fix Released

Bug description:
  * Impact

  When clicking on a package from a PPA in update-manager, the "Changes
  for XXX versions:" section will say:

  "This update does not come from a source that supports changelogs."

  Which seems a side effect of https://blog.launchpad.net/ppa/new-
  domain-names-for-ppas , the code filter on ppa.launchpad.net in the
  url where those are using ppa.launchpadcontent.net now

  * Test case

  - enable a ppa including an update for a package you have installed
  - start update-manager and select that package
  - check the long description at the bottom
   
  it should display the changelog entry for the update

  * Regression potential

  The change is in the _extract_ppa_changelog_uri() function so a
  potential issue would impact updates coming from a ppa. Verify that
  those are correctly listed and include a valid description

  -----------------------------------------------

  The reason is that in _extract_ppa_changelog_uri() in
  /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py it checks
  only for ppa.launchpad.net but nowadays the URI will contain
  ppa.launchpadcontent.net instead.

  With the below patch it will correctly display the changelogs:

  --- /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py.orig	2024-04-16 11:56:33.000000000 +0200
  +++ /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py	2024-06-08 20:33:51.462435498 +0200
  @@ -338,7 +338,7 @@ class MyCache(DistUpgrade.DistUpgradeCac

           cdt = self[name].candidate
           for uri in cdt.uris:
  -            if urlsplit(uri).hostname != "ppa.launchpad.net":
  +            if urlsplit(uri).hostname not in ("ppa.launchpad.net", "ppa.launchpadcontent.net"):
                   continue
               match = re.search("http.*/(.*)/(.*)/ubuntu/.*", uri)
               if match is not None:

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/2068809/+subscriptions