[Bug 2067907] Re: systemd tools fail to mount disk images with btrfs filesystems

[Nick Rosbrook]

I have verified the fix using systemd 255.4-1ubuntu8.2 from noble-
proposed:

nr at six:/t/t/mkosi$ apt policy systemd
systemd:
  Installed: 255.4-1ubuntu8.2
  Candidate: 255.4-1ubuntu8.2
  Version table:
 *** 255.4-1ubuntu8.2 100
        100 http://us.archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     255.4-1ubuntu8.2~ppa4 500
        500 https://ppa.launchpadcontent.net/enr0n/systemd/ubuntu noble/main amd64 Packages
     255.4-1ubuntu8.1 500
        500 http://us.archive.ubuntu.com/ubuntu noble-updates/main amd64 Packages
     255.4-1ubuntu8 500
        500 http://us.archive.ubuntu.com/ubuntu noble/main amd64 Packages

nr at six:/t/tmp.fAC46XxQnY$ git clone https://github.com/systemd/mkosi
Cloning into 'mkosi'...
remote: Enumerating objects: 21509, done.
remote: Counting objects: 100% (21509/21509), done.
remote: Compressing objects: 100% (6472/6472), done.
remote: Total 21509 (delta 14871), reused 20817 (delta 14654), pack-reused 0
Receiving objects: 100% (21509/21509), 5.91 MiB | 1.78 MiB/s, done.
Resolving deltas: 100% (14871/14871), done.
nr at six:/t/tmp.fAC46XxQnY$ cd mkosi/
nr at six:/t/t/mkosi$ ./bin/mkosi -d fedora -t disk --tools-tree=default -f

[ ...snip... ]

nr at six:/t/t/mkosi$ sudo systemd-repart --image mkosi.output/image.raw
[sudo] password for nr: 
No machine ID set, using randomized partition UUIDs.
TYPE                                 LABEL       UUID                                 PARTNO FILE   RAW SIZE     SIZE >
esp                                  esp         a2afefbe-5065-4679-9a40-2768cb2e608b 0           1073741824     1.0G >
21686148-6449-6e6f-744e-656564454649 linux       4410a7c2-8d1d-4a3e-a737-52a6aa7a18f5 1              1048576     1.0M >
root-x86-64                          root-x86-64 67d027f2-ab0f-4102-a6bb-6a5690412d60 2           3016753152     2.8G >
                                                                                                             Σ = 3.8G >

 ▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░
 │                             ├─ root-x86-64                                                                         
 │                             └─ linux                                                                               
 └─ esp                                                                                                               

No changes.


** Tags removed: verification-needed-noble
** Tags added: verification-done-noble

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/2067907

Title:
  systemd tools fail to mount disk images with btrfs filesystems

Status in systemd package in Ubuntu:
  Fix Committed
Status in systemd source package in Noble:
  Fix Committed

Bug description:
  SRU Justification

  [Impact]

  In Ubuntu Noble, systemd-repart fail to mount images with btrfs
  filesystems in them. This is because the kernel removed the
  "norecovery" mount option which systemd-repart adds in when mounting
  filesystems from disk images.

  Commit which removed "norecovery" in the kernel:
  https://github.com/torvalds/linux/commit/a1912f712188291f9d7d434fba155461f1ebef66.

  [Fix]

  The issue was worked around upstream in systemd in
  https://github.com/systemd/systemd/pull/32892 and
  https://github.com/systemd/systemd/pull/32948.

  [Test]

  To reproduce:

  git clone https://github.com/systemd/mkosi
  cd mkosi
  bin/mkosi -d fedora -t disk --tools-tree=default -f
  sudo systemd-repart --image mkosi.output/image.raw
  The last command will fail with "Failed to mount image: Invalid argument". After backporting the two systemd commits, the last command will succeed.

  [Regression Potential]

  Low, the systemd commits only change behavior for btrfs filesystems,
  which are currently not working at all. The commits have been
  backported to the systemd stable releases and we've had no reports of
  any issues caused by backporting these commits.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/2067907/+subscriptions