[Bug 2069360] Re: apport-autoreport.service fails if autoreporting is disabled

[Benjamin Drung]

The fix for this bug is staged for the next oracular upload.

** Description changed:

+ [ Impact ]
+ 
  apport-autoreport.service fails if auto-reporting is disabled:
  
  ```
- $ systemctl status apport-autoreport.service 
+ $ systemctl status apport-autoreport.service
  × apport-autoreport.service - Process error reports when automatic reporting is enabled
-      Loaded: loaded (/usr/lib/systemd/system/apport-autoreport.service; static)
-      Active: failed (Result: exit-code) since Thu 2024-06-13 21:55:08 CEST; 1h 9min ago
+      Loaded: loaded (/usr/lib/systemd/system/apport-autoreport.service; static)
+      Active: failed (Result: exit-code) since Thu 2024-06-13 21:55:08 CEST; 1h 9min ago
  TriggeredBy: ● apport-autoreport.timer
-              ● apport-autoreport.path
-     Process: 1059564 ExecStart=/usr/share/apport/whoopsie-upload-all --timeout 20 (code=exited, status=1/FAILURE)
-    Main PID: 1059564 (code=exited, status=1/FAILURE)
-         CPU: 86ms
+              ● apport-autoreport.path
+     Process: 1059564 ExecStart=/usr/share/apport/whoopsie-upload-all --timeout 20 (code=exited, status=1/FAILURE)
+    Main PID: 1059564 (code=exited, status=1/FAILURE)
+         CPU: 86ms
  
  Jun 13 21:55:08 host systemd[1]: Starting apport-autoreport.service - Process error reports when automatic reporting is enabled...
  Jun 13 21:55:08 host whoopsie-upload-all[1059564]: ERROR: whoopsie.path is not enabled
  Jun 13 21:55:08 host systemd[1]: apport-autoreport.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 21:55:08 host systemd[1]: apport-autoreport.service: Failed with result 'exit-code'.
  Jun 13 21:55:08 host systemd[1]: Failed to start apport-autoreport.service - Process error reports when automatic reporting is enabled.
  ```
+ 
+ This service failure might mislead user thinking that there is a
+ problem.
+ 
+ [ Test Plan ]
+ 
+ 1. Disable auto-reporting in the system setting
+ 2. Produce a crash, e.g. by running divide-by-zero from chaos-marmosets
+ 3. Check that apport-autoreport.service is failing as above
+ 4. Upgrade Apport to the fixed version
+ 5. Restart apport-autoreport.service
+ 6. apport-autoreport.service should exit successfully
+ 
+ [ Where problems could occur ]
+ 
+ This code change touches the auto-reporting part. Failures there could
+ lead to less bugs being forwarded to the error tracker. This might be
+ noticeable when looking at the number of submissions.

** Also affects: apport (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Changed in: apport (Ubuntu)
       Status: New => Fix Committed

** Changed in: apport (Ubuntu Noble)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/2069360

Title:
  apport-autoreport.service fails if autoreporting is disabled

Status in Apport:
  Fix Committed
Status in apport package in Ubuntu:
  Fix Committed
Status in apport source package in Noble:
  New

Bug description:
  [ Impact ]

  apport-autoreport.service fails if auto-reporting is disabled:

  ```
  $ systemctl status apport-autoreport.service
  × apport-autoreport.service - Process error reports when automatic reporting is enabled
       Loaded: loaded (/usr/lib/systemd/system/apport-autoreport.service; static)
       Active: failed (Result: exit-code) since Thu 2024-06-13 21:55:08 CEST; 1h 9min ago
  TriggeredBy: ● apport-autoreport.timer
               ● apport-autoreport.path
      Process: 1059564 ExecStart=/usr/share/apport/whoopsie-upload-all --timeout 20 (code=exited, status=1/FAILURE)
     Main PID: 1059564 (code=exited, status=1/FAILURE)
          CPU: 86ms

  Jun 13 21:55:08 host systemd[1]: Starting apport-autoreport.service - Process error reports when automatic reporting is enabled...
  Jun 13 21:55:08 host whoopsie-upload-all[1059564]: ERROR: whoopsie.path is not enabled
  Jun 13 21:55:08 host systemd[1]: apport-autoreport.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 21:55:08 host systemd[1]: apport-autoreport.service: Failed with result 'exit-code'.
  Jun 13 21:55:08 host systemd[1]: Failed to start apport-autoreport.service - Process error reports when automatic reporting is enabled.
  ```

  This service failure might mislead user thinking that there is a
  problem.

  [ Test Plan ]

  1. Disable auto-reporting in the system setting
  2. Produce a crash, e.g. by running divide-by-zero from chaos-marmosets
  3. Check that apport-autoreport.service is failing as above
  4. Upgrade Apport to the fixed version
  5. Restart apport-autoreport.service
  6. apport-autoreport.service should exit successfully

  [ Where problems could occur ]

  This code change touches the auto-reporting part. Failures there could
  lead to less bugs being forwarded to the error tracker. This might be
  noticeable when looking at the number of submissions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/2069360/+subscriptions