[Bug 2067071] Re: cannot upgrade from 23.10 to 24.04, error in _install_t64_replacement_packages

[Andreas Hasenack]

Hello miccs, or anyone else affected,

Accepted ubuntu-release-upgrader into noble-proposed. The package will
build now and be available at
https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:24.04.19
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-release-upgrader (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2067071

Title:
  cannot upgrade from 23.10 to 24.04, error in
  _install_t64_replacement_packages

Status in ubuntu-release-upgrader package in Ubuntu:
  Invalid
Status in ubuntu-release-upgrader source package in Noble:
  Fix Committed

Bug description:
  [Impact]

  Upgrades to Noble may crash while searching for t64 replacement
  packages.

  [Test Plan]

  One way to reproduce this is by setting Pin-Priority: -1 for a t64
  replacement package so that `replacement` will have no candidate.

  $ apt install -y libts0
  $ cat > /etc/apt/preferences.d/lp2067071  << EOF
  Package: libts0t64
  Pin: release a=noble
  Pin-Priority: -1
  EOF
  $ do-release-upgrade

  Before the patch, that will lead to the same crash shown in this bug
  report.

  [Where problems could occur]

  The patch is confined to the t64 replacement quirk. Any other issues
  would be there. The fix is to simply make sure the replacement has a
  candidate (i.e. replacement.candidate is not None) before accessing
  more attributes.

  [Original Description]

  it crashes while calculating space - cannot proceed to package
  downloading.

  short from the logs:

  File "/tmp/ubuntu-release-upgrader-4lhpwkx7/DistUpgrade/DistUpgradeCache.py", line 497, in pre_upgrade_rule
      self.quirks.run("PreDistUpgradeCache")
    File "/tmp/ubuntu-release-upgrader-4lhpwkx7/DistUpgrade/DistUpgradeQuirks.py", line 95, in run
      func()
    File "/tmp/ubuntu-release-upgrader-4lhpwkx7/DistUpgrade/DistUpgradeQuirks.py", line 191, in PreDistUpgradeCache
      self._install_t64_replacement_packages()
    File "/tmp/ubuntu-release-upgrader-4lhpwkx7/DistUpgrade/DistUpgradeQuirks.py", line 1845, in _install_t64_replacement_packages
      if replacement.candidate._cand != ver:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  AttributeError: 'NoneType' object has no attribute '_cand'

  full logs attached as files.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/2067071/+subscriptions