[Bug 2069433] Re: Enabling new pockets does not enable deb-src for them, even if source code is enabled

[Robie Basak]

> ...you can see it is in a mixed state

For the Test Plan, given that the justification for the SRU is the
behaviour of the Source Code flag in the UI, this must be tested.
Otherwise it'd be sufficient for some mistake to result in the SRU being
"verified" when the actual problem we're trying to fix isn't confirmed
fixed.

Please add to the Test Plan to ensure that the flag in the UI reports
correctly after a reload.

Unless I've misunderstood?

>   * Reload the source code state when reloading sources.list (LP:
#2069433)

I won't block on this but for next time I suggest writing changelogs in
SRUs from the perspective of the user. The SRU justification is that the
UI is being fixed and/or we want to avoid splitting the deb822 paragraph
into two, but neither of these can be inferred from this message. It
would be nice to provide the user with this information so that they can
decide if/when they want to receive the update (for users who care by
using apt-listchanges, etc). How you fixed it is IMHO secondary (but can
still be mentioned if you wish).

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/2069433

Title:
  Enabling new pockets does not enable deb-src for them, even if source
  code is enabled

Status in software-properties package in Ubuntu:
  Fix Released
Status in software-properties source package in Noble:
  Incomplete

Bug description:
  [Impact]
  If you have Source Code enabled, and you change the pockets configuration to "all pockets", it will add -backports without source code. The Source Code flag will still be set in the UI, but after a reload, you can see it is in a mixed state.

  This is more notable now, because this splits up the deb822 paragraph
  into two: One for the deb, and one for deb-src, whereas it should
  remain one.

  [Test plan]
  1. Turn on source code, save and refresh sources, close app
  2. Turn "recommended updates" to "all updates", observe that -backports got added with deb-src, to the existing paragraph.

  [Where problems could occur]
  This incurs a performance regression, as we need to check the state of the source code flag after reloading sources. That said, this is of course necessary for the source code flag to be correct after reloading modified sources (it gets reset to False when reloading). And since we run in a dbus service, we may just be reloading without having made the changes ourselves, so we can't just cache the old value and restore it.

  That said, software-properties already times out on my oracular
  system.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions