[Bug 244250] Re: Spurious reboot notifications caused by libssl upgrades.

[Adrien Nader]

I did some archeology because I'm trying to get rid of the Ubuntu delta
compared to Debian.

I think the code change in 1.0.0e-2ubuntu3 is problematic. No blame: the
shell script was already hairy and difficult to understand and in order
to spot that, I had to identify a chunk of dead code, remove it, and
come back on the script again months later.

In short, I'm going to drop the postinst.

The current code is easier to read as it's shorter:

    if [ "$1" = "configure" ]
    then
        if [ ! -z "$2" ] && [ ! -x /usr/lib/needrestart/apt-pinvoke ] ; then
            if ! pidof /usr/lib/xorg/Xorg > /dev/null && [ -x /usr/share/update-notifier/notify-reboot-required ]; then
                    /usr/share/update-notifier/notify-reboot-required
            fi
        fi
    fi

IOW, apt-pinvoke must be chmod -x (i.e. we're on Desktop), X must not be
running (i.e. we're on Server), then we'll call notify-reboot-required.

Of course, with wayland now, you could be on desktop with a GUI and pass
the pidof test. Still, that's not the intent and wasn't. Pidof is a poor
proxy and I'll rather remove the code than add another special case.

I could _maybe_ be convinced of removing the pidof test but keeping the
apt-pinvoke one though.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to openssl in Ubuntu.
https://bugs.launchpad.net/bugs/244250

Title:
  Spurious reboot notifications caused by libssl upgrades.

Status in openssl package in Ubuntu:
  Fix Released

Bug description:
  The postinst script for libssl0.9.8 currently has a bug where it sends
  a reboot notifcation whenever libssl is configured.  So reconfiguring
  libssl0.9.8 or even just installing libssl0.9.8 will result in a
  reboot notification.  Sending of the reboot notification should
  definitely be moved inside the upgrading guard.  The correct fix is
  likely to move it inside a version comparison guard for particular
  important updates like Colin suggests below -- this is what every
  other standard package using notify-reboot-required does.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openssl/+bug/244250/+subscriptions