[Bug 2086771] [NEW] pkcon crashes in transaction with user prompt

[Alessandro Astone]

Public bug reported:

[ Impact ]

`pkcon install <pkg>` crashes after install, and likewise
`pkcon remove <pkg>` crashes after removal.

More in general, all pkcon transactions that prompt the user with a
question like "Proceed with changes? [N/y]" will crash after completing
the transaction.

This is fixed by correcting a reference counting issue which was causing
a double-free.

[ Test Case 1 ]
1. Run `pkcon install 2048`
2. Answer `n` to "Proceed with changes? [N/y]"
3. Verify that pkcon does not print
     GLib-GObject-CRITICAL **: 12:02:00.011: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ Test Case 2 ]
1. Run `pkcon install 2048`
2. Answer `y` to "Proceed with changes? [N/y]"
3. Complete the install
4. Verify that pkcon did not crash with segmentation fault

[ Where things could go wrong ]
If the fix is too broad, we could be leaking memory, but pkcon is not a daemon anyways.
If the fix is not broad enough, the issue might still be happening in specific cases we haven't tested.

** Affects: packagekit (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to packagekit in Ubuntu.
https://bugs.launchpad.net/bugs/2086771

Title:
  pkcon crashes in transaction with user prompt

Status in packagekit package in Ubuntu:
  New

Bug description:
  [ Impact ]

  `pkcon install <pkg>` crashes after install, and likewise
  `pkcon remove <pkg>` crashes after removal.

  More in general, all pkcon transactions that prompt the user with a
  question like "Proceed with changes? [N/y]" will crash after
  completing the transaction.

  This is fixed by correcting a reference counting issue which was
  causing a double-free.

  [ Test Case 1 ]
  1. Run `pkcon install 2048`
  2. Answer `n` to "Proceed with changes? [N/y]"
  3. Verify that pkcon does not print
       GLib-GObject-CRITICAL **: 12:02:00.011: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

  [ Test Case 2 ]
  1. Run `pkcon install 2048`
  2. Answer `y` to "Proceed with changes? [N/y]"
  3. Complete the install
  4. Verify that pkcon did not crash with segmentation fault

  [ Where things could go wrong ]
  If the fix is too broad, we could be leaking memory, but pkcon is not a daemon anyways.
  If the fix is not broad enough, the issue might still be happening in specific cases we haven't tested.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/packagekit/+bug/2086771/+subscriptions