[Bug 2062535] Re: zip fails when filenames contain unicode characters

[Stefan]

Tested on noble, looks good. Thanks!


```
$ dpkg -l zip
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
ii  zip            3.0-13build1 amd64        Archiver for .zip files


$ ll
total 132
drwxr-xr-x  2 user users   4096 Nov 15 12:56 ./
drwxrwxrwt 39 root root  126976 Nov 15 15:26 ../
-rw-r--r--  1 user users      0 Nov 15 12:55 äbc.txt


$ zip test.zip äbc.txt 
*** buffer overflow detected ***: terminated


zip error: Interrupted (aborting)


$ apt policy zip
zip:
  Installed: 3.0-13build1
  Candidate: 3.0-13build1
  Version table:
     3.0-13ubuntu0.1 100
        100 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages
 *** 3.0-13build1 500
        500 http://archive.ubuntu.com/ubuntu noble/main amd64 Packages
        100 /var/lib/dpkg/status


$ sudo apt install zip=3.0-13ubuntu0.1
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages will be upgraded:
  zip
1 upgraded, 0 newly installed, 0 to remove and 400 not upgraded.
Need to get 176 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 zip amd64 3.0-13ubuntu0.1 [176 kB]
Fetched 176 kB in 0s (365 kB/s)
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 244512 files and directories currently installed.)
Preparing to unpack .../zip_3.0-13ubuntu0.1_amd64.deb ...
Unpacking zip (3.0-13ubuntu0.1) over (3.0-13build1) ...
Setting up zip (3.0-13ubuntu0.1) ...
Processing triggers for man-db (2.12.0-4build2) ...


$ dpkg -l zip
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version         Architecture Description
+++-==============-===============-============-=================================
ii  zip            3.0-13ubuntu0.1 amd64        Archiver for .zip files


$ zip test.zip äbc.txt 
  adding: äbc.txt (stored 0%)
```

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to zip in Ubuntu.
https://bugs.launchpad.net/bugs/2062535

Title:
  zip fails when filenames contain unicode characters

Status in zip package in Ubuntu:
  Fix Released
Status in zip source package in Noble:
  Fix Committed
Status in zip source package in Oracular:
  Fix Committed
Status in zip source package in Plucky:
  Fix Released

Bug description:
  [ Impact ]

   * zip in noble is built with _FORTIFY_SOURCE=3 and the code is bug
  with buffer overflow when filename contains non ascii characters. So
  it crashes at runtime.

  [ Test Plan ]

   * install zip from proposed
   * run following commands:
     touch ä
     zip x.zip ä
   * It shouldn't crash.

  [ Where problems could occur ]

   * The patch has been included in fedora 40 and tested there.
   * If the patch is still wrong to calculate the buffer size, zip continues to crash.

  [ Other Info ]

   * None

  [Original description]

  Steps to reproduce: command line
  $ touch ä
  $ zip x.zip ä

  will result in

  > *** buffer overflow detected ***: terminated
  >
  >
  > zip error: Interrupted (aborting)

  cf. https://bugzilla.redhat.com/show_bug.cgi?id=2165653

  ProblemType: Bug
  DistroRelease: Ubuntu 24.04
  Package: zip 3.0-13build1
  Uname: Linux 6.8.6-060806-generic x86_64
  ApportVersion: 2.28.1-0ubuntu1
  Architecture: amd64
  CasperMD5CheckResult: unknown
  CurrentDesktop: XFCE
  Date: Fri Apr 19 12:34:09 2024
  SourcePackage: zip
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zip/+bug/2062535/+subscriptions