[Bug 2089049] [NEW] systemd-socket-activation test can be flaky

[Nick Rosbrook]

Public bug reported:

There is a race condition in this test when checking the the ssh.service
ActiveState after calling systemctl reload. E.g. from [1]:

1537s autopkgtest [11:13:00]: test systemd-socket-activation: [-----------------------
1538s Stopping ssh.service...
1538s Checking that ssh.socket is active and listening...
1538s Checking that ssh.service is inactive/dead...
1538s Checking that a connection attempt activates ssh.service...
1539s Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
1539s Checking that sshd can be re-executed...
1539s Fail: ssh.service: expected ActiveState=active, but got ActiveState=reloading
1539s autopkgtest [11:13:02]: test systemd-socket-activation: -----------------------]
1540s systemd-socket-activation FAIL non-zero exit status 1

This is because we immediately check the active state after reload, and
do not account for the "reloading" state.

[1] https://autopkgtest.ubuntu.com/results/autopkgtest-
plucky/plucky/s390x/o/openssh/20241117_111312_632ee@/log.gz

** Affects: openssh (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to openssh in Ubuntu.
https://bugs.launchpad.net/bugs/2089049

Title:
  systemd-socket-activation test can be flaky

Status in openssh package in Ubuntu:
  New

Bug description:
  There is a race condition in this test when checking the the
  ssh.service ActiveState after calling systemctl reload. E.g. from [1]:

  1537s autopkgtest [11:13:00]: test systemd-socket-activation: [-----------------------
  1538s Stopping ssh.service...
  1538s Checking that ssh.socket is active and listening...
  1538s Checking that ssh.service is inactive/dead...
  1538s Checking that a connection attempt activates ssh.service...
  1539s Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
  1539s Checking that sshd can be re-executed...
  1539s Fail: ssh.service: expected ActiveState=active, but got ActiveState=reloading
  1539s autopkgtest [11:13:02]: test systemd-socket-activation: -----------------------]
  1540s systemd-socket-activation FAIL non-zero exit status 1

  This is because we immediately check the active state after reload,
  and do not account for the "reloading" state.

  [1] https://autopkgtest.ubuntu.com/results/autopkgtest-
  plucky/plucky/s390x/o/openssh/20241117_111312_632ee@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/2089049/+subscriptions