[Bug 2073935] Re: tests/integration/test_hookutils.py::T::test_recent_syslog fails on s390x

[Benjamin Drung]

Verified successful autopkgtest on
https://autopkgtest.ubuntu.com/packages/apport for 2.28.1-0ubuntu3.3:

* amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/amd64/a/apport/20241114_155914_7aded@/log.gz
* arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/arm64/a/apport/20241114_152854_d2cf5@/log.gz
* armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/armhf/a/apport/20241114_153245_54069@/log.gz
* ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/ppc64el/a/apport/20241114_153720_f72b7@/log.gz
* s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/s390x/a/apport/20241114_152611_b90ee@/log.gz

All test were successful, except for these tests on s390x:

```
FAILED tests/unit/test_problem_report.py::T::test_modify
FAILED tests/unit/test_report.py::T::test_report_from_systemd_coredump_storage_journal
FAILED tests/integration/test_problem_report.py::T::test_big_file
FAILED tests/integration/test_problem_report.py::T::test_write_file
```

These four test failures are caused by bug #2076269 which I will address
in a future SRU (summary: it's a flaw of the test, but not the non-test
code).

** Tags removed: verification-needed verification-needed-noble
** Tags added: verification-done verification-done-noble

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/2073935

Title:
  tests/integration/test_hookutils.py::T::test_recent_syslog fails on
  s390x

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  The recent syslog in Apport reports might not be complete. This bug
  causes the test_recent_syslog to fail sometimes.

  [ Test Plan ]

  Check that the fixed Apport does not have failing unit-and-
  integration-tests autopkgtests on all archs.

  [ Where problems could occur ]

  The patch fixes apport.hookutils.recent_syslog. This could lead to
  more syslog output in bug report making the report longer.

  [ Original report ]

  The Apport 2.29.0 test case
  `tests/integration/test_hookutils.py::T::test_recent_syslog` fails on
  s390x:

  ```
  349s =================================== FAILURES ===================================
  349s _____________________________ T.test_recent_syslog _____________________________
  349s
  349s self = <tests.integration.test_hookutils.T testMethod=test_recent_syslog>
  349s
  349s     def test_recent_syslog(self):
  349s         """recent_syslog"""
  349s         self.assertEqual(
  349s             apport.hookutils.recent_syslog(re.compile("."), path="/nonexisting"), ""
  349s         )
  349s         self.assertEqual(
  349s             apport.hookutils.recent_syslog(re.compile("ThisCantPossiblyHitAnything")),
  349s             "",
  349s         )
  349s         if os.path.exists("/run/systemd/system") or os.access(
  349s             "/var/log/syslog", os.R_OK
  349s         ):
  349s >           self.assertNotEqual(len(apport.hookutils.recent_syslog(re.compile("."))), 0)
  349s E           AssertionError: 0 == 0
  349s
  349s tests/integration/test_hookutils.py:208: AssertionError
  349s ----------------------------- Captured stderr call -----------------------------
  349s tail: cannot open '/nonexisting' for reading: No such file or directory
  ```

  Full log: https://autopkgtest.ubuntu.com/results/autopkgtest-
  oracular/oracular/s390x/a/apport/20240722_004756_30d6c@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/2073935/+subscriptions