[Bug 2076419] Please test proposed package

[Robie Basak]

Hello Julian, or anyone else affected,

Accepted lxml into noble-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/lxml/5.2.1-1ubuntu0.1
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to lxml in Ubuntu.
https://bugs.launchpad.net/bugs/2076419

Title:
  lxml: Does not respect compiler flags

Status in lxml package in Ubuntu:
  Fix Released
Status in lxml source package in Noble:
  Fix Committed

Bug description:
  [Impact]
  The packaging does not respect compiler flags, notably hardening flags like the stack protector, as well as frame pointer, as it never uses dpkg-buildflags and is still old manual style.

  This means there is a higher security risk, which given the nature of
  the library seems ill-advised, and the lack of frame pointers hampers
  profiling.

  [Test plan]
  Skim at the build log and see that the build flags have been passed, notably stuff like

  -fno-strict-overflow
  -Werror=implicit-function-declaration
  -fno-omit-frame-pointer
  -mno-omit-leaf-frame-pointer
  -fstack-protector-strong
  -fstack-clash-protection
  -Wformat
  -Werror=for

  Run https://gist.github.com/julian-
  klode/85e55553f85c410a1b856a93dce77208 on the ELF binaries and ensure
  that all lines have -fno-omit-frame-pointer

  Run a smoke test to see the parser still works:

  from lxml import etree
  from urllib.request import urlopen

  with urlopen("https://www.w3.org/TR/REC-xml/REC-xml-20081126.xml") as xml:
      xml=xml.read()
  tree=etree.fromstring(xml, base_url="https://www.w3.org/TR/REC-xml/REC-xml-20081126.xml")

  for element in tree.iter():
      print(element)

  print(etree.tostring(tree))

  Expected result: XML output, with no exception raised and a zero exit
  status. There is no need to verify the precise output.

  [Where problems could occur]
  Hardening flags could surface existing (possibly security) bugs that have been asymptomatic so far; frame pointers will incur some slow down.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxml/+bug/2076419/+subscriptions