[Bug 2083651] Re: debhelper 13.18ubuntu2 ignores arch-specific overrides causing lintian 2.118.0ubuntu1 to FTBFS

[Brian Murray]

Hello Chris, or anyone else affected,

Accepted debhelper into oracular-proposed. The package will build now
and be available at
https://launchpad.net/ubuntu/+source/debhelper/13.18ubuntu2.1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
oracular to verification-done-oracular. If it does not fix the bug for
you, please add a comment stating that, and change the tag to
verification-failed-oracular. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: debhelper (Ubuntu Oracular)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-oracular

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to debhelper in Ubuntu.
https://bugs.launchpad.net/bugs/2083651

Title:
  debhelper 13.18ubuntu2 ignores arch-specific overrides causing lintian
  2.118.0ubuntu1 to FTBFS

Status in debhelper package in Ubuntu:
  In Progress
Status in debhelper source package in Oracular:
  Fix Committed
Status in debhelper source package in Plucky:
  In Progress

Bug description:
  [ Impact ]

  * This blocks the SRU tracked in bug 2084708.

  * A change in debhelper caused a regression in packages which used
  arch-specific debhelper configs.

  * This regression in particular causes lintian to FTBFS due to failing
  build-time tests which rely on specifying arch-specific lintian
  overrides ( e.g. package_name.lintian-overrides.amd64). This SRU will
  ensure lintian can build in Oracular and will not block other SRUs of
  packages which rely on these types of overrides.

  * The upload fixes the regression by cherry-picking changes from
  upstream Debian  to handle architecture specific overrides[0].

  [0]
  https://salsa.debian.org/debian/debhelper/-/commit/214c2a299dfcc1f0cb79ea4a0e80d67df54be19a

  [ Test Plan ]

  * Rebuild Lintian with the new version of debhelper, ensure it builds,
  and autopkgtests pass.

  * Ensure debhelpers autopkgtests and rev-dep's autopkgtests pass

  [ Where problems could occur ]

  * The upload overall feels low risk. The low hanging fruit here is
  that the patch is applied incorrectly (typo, incomplete, etc) and
  would cause the issue to not be fixed or even to cause debhelper to
  FTBFS now. I've demonstrated this isn't the case with passing PPA
  builds of both debhelper and lintian.

  * The more interesting scenario would be the potential for other
  packages which rely on the faulty behavior and will now appear to
  regress with the inclusion of the correct overrides. Although this
  would have to be something pretty contrived - like the lintian build
  tests which check for the existence of the overrides - since lintian
  overrides (AFAIU) typically suppress warning/errors instead of
  generating them.

  [ Original Description ]

  lintian 2.118.0ubuntu1 had previously built[0], but now fails to build
  from source [1]. Version  2.118.2ubuntu1 stuck in oracular-proposed
  currently fails to build for the same reason.

  The particular failure is a build time test failure:

  # Hints do not match
  #
  # --- debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/hints.specified.calibrated
  # +++ debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/hints.actual.parsed
  # -fields-multi-arch-same-package-has-arch-specific-overrides-nonrel (binary): alien-tag foo [usr/share/lintian/overrides/fields-multi-arch-same-package-has-arch-specific-overrides-nonrel:1]
  # -fields-multi-arch-same-package-has-arch-specific-overrides (binary): alien-tag foo [usr/share/lintian/overrides/fields-multi-arch-same-package-has-arch-specific-overrides:1]
  # +
  #
  # Missing tags:
  #   alien-tag
  #
  #   Failed test 'Lintian passes for fields-multi-arch-same-package-has-arch-specific-overrides'
  #   at /<<PKGBUILDDIR>>/lib/Test/Lintian/Run.pm line 343.
  # Looks like you failed 1 test of 1.
  debian/test-out/eval/checks/debian/lintian-overrides/mystery/fields-multi-arch-same-package-has-arch-specific-overrides/generic.t .....
  Dubious, test returned 1 (wstat 256, 0x100)
  Failed 1/1 subtests

  [0] https://launchpad.net/ubuntu/+source/lintian/2.118.0ubuntu1/+build/28700466
  [1] https://launchpadlibrarian.net/749250106/buildlog_ubuntu-oracular-amd64.lintian_2.118.0ubuntu1_BUILDING.txt.gz
  [2] https://launchpad.net/ubuntu/+source/lintian/2.118.2ubuntu1/+build/29094257

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/2083651/+subscriptions