[Bug 2054092] Re: [SRU] Add support for FIT images to rpi config

[Timo Aaltonen]

Hello Dave, or anyone else affected,

Accepted u-boot into noble-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/u-boot/2024.01+dfsg-1ubuntu5.1 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: u-boot (Ubuntu Noble)
       Status: Confirmed => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to u-boot in Ubuntu.
https://bugs.launchpad.net/bugs/2054092

Title:
  [SRU] Add support for FIT images to rpi config

Status in u-boot package in Ubuntu:
  Fix Released
Status in u-boot source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  The current u-boot-rpi package does not include support for FIT
  images. Enabling this feature has been requested by an internal team.

  [ Test Plan ]

  To test FIT image generation:

  * Flash the Ubuntu Server for Raspberry Pi 24.04.1 image [1] to an SD card
  * Place the following content in a file named "image.its":

  /dts-v1/;
  / {
      description = "FIT payload";
      #address-cells = <2>;
      images {
          kernel {
              description = "kernel";
              data = /incbin/("vmlinux.zst");
              type = "kernel";
              arch = "arm64";
              os = "linux";
              compression = "zstd";
              load =  <0x200000>;
              entry = <0x200000>;
              hash {
                  algo = "sha1";
              };
          };
          initrd {
              description = "initramfs";
              data = /incbin/("initrd.cpio.zst");
              type = "ramdisk";
              arch = "arm64";
              os = "linux";
              compression = "none";
              hash {
                  algo = "sha1";
              };
          };
      };
      configurations {
          default = "standard";
          standard {
              description = "config";
              kernel = "kernel";
              ramdisk = "initrd";
              hash {
                  algo = "sha1";
              };
          };
      };
  };

  * Run mkimage -f image.its -T flat_dt
  * Observe failure with current version
  * Upgrade u-boot-rpi to version in -proposed
  * Run mkimage -f image.its -T flat_dt
  * Observe successful generation of image

  To test no regression in boot operation:

  * Flash the Ubuntu Server for Raspberry Pi 24.04.1 image [1] to an SD card
  * Modify the boot sequence to include u-boot. In config.txt:
    - Set kernel=uboot_rpi_4.bin (adjust as appropriate for test board)
    - Set device_tree_address=0x03000000
  * sudo reboot
  * Ensure boot succeeds

  [1]:
  http://cdimage.ubuntu.com/releases/24.04.1/release/ubuntu-24.04.1-preinstalled-
  desktop-arm64+raspi.img.xz

  [ Regression Potential ]

  Varied; the u-boot package hasn't been used in the classic images
  since focal (and jammy upgrades includes a quirk to remove it from the
  boot chain), so the impact on the server and desktop images should be
  nil even if it failed entirely. However, the Core images still use
  u-boot so its operation should be checked on all boards supported by
  Core 24 (specifically the Pi 3, 4, and 5 series) by following the
  second part of the test plan above.

  [ Original Description ]

  Support for signed FIT images has been requested; the following config
  items should be enabled for the rpi 3 and 4 configurations (in both
  armhf and arm64):

  CONFIG_FIT=y
  CONFIG_FIT_SIGNATURE=y
  CONFIG_FIT_VERBOSE=y
  CONFIG_FIT_PRINT=y
  CONFIG_TOOLS_FIT=y
  CONFIG_TOOLS_FIT_SIGNATURE=y
  CONFIG_TOOLS_FIT_VERBOSE=y
  CONFIG_TOOLS_FIT_PRINT=y
  CONFIG_ZSTD=y

  Check this doesn't affect core 24 images (there will inevitably be a
  size increase as a result of enabling more flags; this is probably a
  good time to unseed u-boot on the pi images for oracular).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/2054092/+subscriptions