[Bug 2103526] Re: [FFe] Allow 'AptSolverDump' field for apt solver 3 reports

[Paride Legovini]

For posterity: I discussed this FFe with Skia and approved it in a side
channel, before sponsoring.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to whoopsie in Ubuntu.
https://bugs.launchpad.net/bugs/2103526

Title:
  [FFe] Allow 'AptSolverDump' field for apt solver 3 reports

Status in whoopsie package in Ubuntu:
  Fix Released

Bug description:
  [Context]

  Apt solver 3 is coming to plucky. Julian, apt's maintainer, would like
  to collect apt solver issues in the Ubuntu Error Tracker. Everything
  is already mostly wired, but `whoopsie` currently doesn't allow the
  `AptSolverDump` field in the produced crashes.

  [Changes]

  This is mostly a one-line change to add `AptSolverDump` to the right
  allow-list.

  Since I'm slowly taking over this mostly unmaintained package, I'm
  also improving some other small things that would be good to be
  evaluated in the FFe:

    * Add some additional logging for more discoverable behavior.
    * Fix some lintian errors.
    * Raise debhelper-compat to 13.

  The exhaustive list of changes can be found on this MP:
  https://code.launchpad.net/~hyask/whoopsie/+git/whoopsie/+merge/482986

  [Test plan]

  Here is a PPA: https://launchpad.net/~hyask/+archive/ubuntu/whoopsie-
  aptsolverdump/+packages

  I've already installed the package from the PPA, and verified the following:
  * systemd .service and .path files are correctly installed at the right place.
  * whoopsie service correctly triggers when something appears in `/var/crash`.
  * The new log lines correctly appear in the journal of the whoopsie service:
  ```
  mars 18 17:44:49 kiffex systemd[1]: Started whoopsie.service - Service uploading crash reports to the Ubuntu Error Tracker.
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Using lock path: /var/lock/whoopsie/lock
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Looking for .upload files in /var/crash
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Found .crash corresponding to .upload (/var/crash/_usr_share_apport_apport.0.crash)
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Crash already uploaded, skipping
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Found .crash corresponding to .upload (/var/crash/_usr_libexec_fwupd_fwupd.0.crash)
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Crash already uploaded, skipping
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Found .crash corresponding to .upload (/var/crash/_usr_bin_seg-fault.1000.crash)
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Parsing /var/crash/_usr_bin_seg-fault.1000.crash.
  mars 18 17:44:49 kiffex whoopsie[1209860]: [17:44:49] Uploading /var/crash/_usr_bin_seg-fault.1000.crash.
  mars 18 17:44:50 kiffex whoopsie[1209860]: [17:44:50] Sent; server replied with: No error
  mars 18 17:44:50 kiffex whoopsie[1209860]: [17:44:50] Response code: 200
  mars 18 17:44:50 kiffex whoopsie[1209860]: [17:44:50] Reported OOPS ID 4e2150de-0418-11f0-999a-fa163e171f02
  mars 18 17:44:50 kiffex systemd[1]: whoopsie.service: Deactivated successfully.
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/whoopsie/+bug/2103526/+subscriptions