[Bug 2104572] Re: Booting the daily noble RISC-V installer image fails

[Nick Rosbrook]

I updated the bug tasks to reflect the fact that this fix is *only*
targeting noble, as per the [ Other Info ] section.

Other than that, I think all of my previous comments have been
addressed, and this is ready to be accepted.

** Changed in: cd-boot-images-riscv64 (Ubuntu)
       Status: In Progress => Invalid

** Also affects: u-boot (Ubuntu Oracular)
   Importance: Undecided
       Status: New

** Also affects: cd-boot-images-riscv64 (Ubuntu Oracular)
   Importance: Undecided
       Status: New

** Also affects: u-boot (Ubuntu Plucky)
   Importance: Undecided
       Status: New

** Also affects: cd-boot-images-riscv64 (Ubuntu Plucky)
   Importance: Undecided
       Status: New

** Changed in: cd-boot-images-riscv64 (Ubuntu Oracular)
       Status: New => Invalid

** Changed in: cd-boot-images-riscv64 (Ubuntu Plucky)
       Status: New => Invalid

** Changed in: u-boot (Ubuntu Oracular)
       Status: New => Invalid

** Changed in: u-boot (Ubuntu Plucky)
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to u-boot in Ubuntu.
https://bugs.launchpad.net/bugs/2104572

Title:
  Booting the daily noble RISC-V installer image fails

Status in cd-boot-images-riscv64 package in Ubuntu:
  Invalid
Status in u-boot package in Ubuntu:
  Invalid
Status in cd-boot-images-riscv64 source package in Noble:
  In Progress
Status in u-boot source package in Noble:
  Invalid
Status in cd-boot-images-riscv64 source package in Oracular:
  Invalid
Status in u-boot source package in Oracular:
  Invalid
Status in cd-boot-images-riscv64 source package in Plucky:
  Invalid
Status in u-boot source package in Plucky:
  Invalid

Bug description:
  [ Impact ]

   * Grub, as provided by cd-boot-images-riscv64, does not properly set the root=
     variable to identify the rootfs.

   * I have downloaded
     https://cdimage.ubuntu.com/ubuntu-server/daily-live/current/plucky-live-
     server-riscv64.iso
     https://cdimage.ubuntu.com/ubuntu-server/noble/daily-live/current/noble-live-
     server-riscv64.iso
     and tried to boot these on a Plucky system.

     Booting the noble image with

     qemu-system-riscv64 -machine virt -m 4G -smp cpus=2 -nographic \
      -kernel /usr/lib/u-boot/qemu-riscv64_smode/u-boot.bin \
      -netdev user,id=net0 \
      -device virtio-net-device,netdev=net0 \
      -drive file=noble-live-server-riscv64.iso,format=raw,if=virtio \
      -drive file=disk,format=raw,if=virtio \
      -device virtio-rng-pc

     ends up in the GRUB rescue console:

     grub> ls $root
     error: invalid file name `hd0,gpt2'.
     grub> ls ($root)/
     efi/ dtb/ ubootefi.var
     grub>

     Same problem with EDK II using

     qemu-system-riscv64 -machine virt -m 4G -smp cpus=2 -nographic \
      -drive if=pflash,format=raw,unit=0,file=/usr/share/qemu-efi-
     riscv64/RISCV_VIRT_CODE.fd,readonly=on \
      -drive if=pflash,format=raw,unit=1,file=RISCV_VIRT_VARS.fd \
      -netdev user,id=net0 \
      -device virtio-net-device,netdev=net0 \
      -drive file=disk,format=raw,if=virtio \
      -device virtio-blk,drive=ISO,bootindex=1 \
      -drive file=noble-live-server-riscv64.iso,if=none,id=ISO \
      -device virtio-rng-pci

     When I emulate a CD-ROM it works

     qemu-system-riscv64 -machine virt -m 4G -smp cpus=2 -nographic \
      -drive if=pflash,format=raw,unit=0,file=/usr/share/qemu-efi-
     riscv64/RISCV_VIRT_CODE.fd,readonly=on \
      -drive if=pflash,format=raw,unit=1,file=RISCV_VIRT_VARS.fd \
      -netdev user,id=net0 \
      -device virtio-net-device,netdev=net0 \
      -drive file=disk,format=raw,if=virtio \
      -device driver=virtio-scsi-pci,id=scsi0 \
      -drive if=none,file=noble-live-server-
     riscv64.iso,format=raw,readonly=on,id=CDROM \
      -device driver=scsi-cd,bus=scsi0.0,drive=CDROM,bootindex=1 \
      -device virtio-rng-pci

     So it seems our current Noble ISO is not properly set up to be used a disk
     image.

  [ Test Plan ]

  * Build a new.iso Noble ISO locally with debian-cd with the proposed
  solution.

  * Boot new.iso as a disk image with:

     qemu-system-riscv64 -machine virt -m 4G -smp cpus=2 -nographic \
      -kernel /usr/lib/u-boot/qemu-riscv64_smode/u-boot.bin \
      -netdev user,id=net0 \
      -device virtio-net-device,netdev=net0 \
      -drive file=new.iso,format=raw,if=virtio \
      -drive file=disk,format=raw,if=virtio \
      -device virtio-rng-pc

  * On booting enter the grub menu and ensure ($root)/.disk/info exists. E.g.
    issue a 'ls ($root)/.disk/info'. This means that the root= variable
    is correctly pointing to the rootfs.

  
  [ Where problems could occur ]

   * The rootfs should be the only filesystem in the image containing a file named
     /.disk/info. If not, we risk loading an incorrect filesystem. With the
     current debian-cd configuration, this is the case.

  [ Other Info ]

   * This bug does not affect Plucky because cd-boot-images-riscv64 is not used in
     there.
   * This bug will not be fixed for Oracular as we will not be spinning new
     images.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cd-boot-images-riscv64/+bug/2104572/+subscriptions