[Bug 2121429] Re: [FFe] New probert rtnetlink implementation

[Skia]

I'm in no position to fully +1 this (not release team, only trainee),
but I've given a first round of review, and this looks good to go.

I see a good amount of automated tests in that PR 👍
Given that this doesn't seem to impact user workflow directly, I don't think it's necessary to have a mandatory test case in the ISO tracker for this one, but please do test that in the dailies as soon as it's available, to avoid being caught by surprise at the last moment.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to subiquity in Ubuntu.
https://bugs.launchpad.net/bugs/2121429

Title:
  [FFe] New probert rtnetlink implementation

Status in probert:
  New
Status in subiquity:
  New
Status in subiquity package in Ubuntu:
  New

Bug description:
  Request
  -------
  We want Subiquity to switch to the new probert rtnetlink implementation, which is written in pure Python instead of C. Earlier, we already switched to the new nl80211 implementation.

  Why Needed
  ----------
  In the past few cycles in Subiquity, there have been reports of python crashes (e.g., Segmentation fault) caused by poor implementation of probert network modules written in C.
  To clear the possibility of memory safety vulnerabilities, we want to stop relying on memory unsafe code in Subiquity, ASAP.

  Having this new implementation in 25.10 will give us more room for
  addressing any potential bugs in the new implementation before the
  change gets more wildely rolled  with the coming LTS.

  What Changed
  ------------
  * The new implementation is based on pyroute2 instead of libnl. It is designed to be as close in behavior as the old implementation in C.

  Code to be merged
  -----------------
  * https://github.com/canonical/probert/pull/160

  Additional information
  ----------------------
  probert is not in the archive, but staged in the subiquity snap.

To manage notifications about this bug go to:
https://bugs.launchpad.net/probert/+bug/2121429/+subscriptions