[Bug 2093420] Re: add-apt-repository --enable-source should work directly on deb822 sources

[Julian Andres Klode]

** Changed in: software-properties (Ubuntu)
     Assignee: (unassigned) => Julian Andres Klode (juliank)

** Changed in: software-properties (Ubuntu)
   Importance: Undecided => Medium

** Tags removed: rls-pp-incoming
** Tags added: foundations-todo

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/2093420

Title:
  add-apt-repository --enable-source should work directly on deb822
  sources

Status in software-properties package in Ubuntu:
  New

Bug description:
  Currently, if you want to enable sources, you need to enter the option
  twice, otherwise you're treated to a somewhat confusing error message
  (assuming you patched python-apt with https://salsa.debian.org/apt-
  team/python-apt/-/merge_requests/99):

  ```
  ❯ sudo add-apt-repository -s
  Enabling deb-src for all repositories.
  Press [ENTER] to continue or Ctrl-c to cancel.
  Warning, missing deb-src for: ## Ubuntu distribution repository
  ##
  ## The following settings can be adjusted to configure which packages to use from Ubuntu.
  ## Mirror your choices (except for URIs and Suites) in the security section below to
  ## ensure timely security updates.
  ##
  ## Types: Append deb-src to enable the fetching of source package.
  ## URIs: A URL to the repository (you may add multiple URLs)
  ## Suites: The following additional suites can be configured
  ##   <name>-updates   - Major bug fix updates produced after the final release of the
  ##                      distribution.
  ##   <name>-backports - software from this repository may not have been tested as
  ##                      extensively as that contained in the main release, although it includes
  ##                      newer versions of some applications which may provide useful features.
  ##                      Also, please note that software in backports WILL NOT receive any review
  ##                      or updates from the Ubuntu security team.
  ## Components: Aside from main, the following components can be added to the list
  ##   restricted  - Software that may not be under a free license, or protected by patents.
  ##   universe    - Community maintained packages. Software in this repository receives maintenance
  ##                 from volunteers in the Ubuntu community, or a 10 year security maintenance
  ##                 commitment from Canonical when an Ubuntu Pro subscription is attached.
  ##   multiverse  - Community maintained of restricted. Software from this repository is
  ##                 ENTIRELY UNSUPPORTED by the Ubuntu team, and may not be under a free
  ##                 licence. Please satisfy yourself as to your rights to use the software.
  ##                 Also, please note that software in multiverse WILL NOT receive any
  ##                 review or updates from the Ubuntu security team.
  ##
  ## See the sources.list(5) manual page for further settings.
  Types: deb-src
  URIs: http://archive.ubuntu.com/ubuntu
  Suites: plucky plucky-updates plucky-backports
  Components: multiverse restricted universe main
  Signed-By: /usr/share/keyrings/ubuntu-archive-keyring.gpg
  Warning, missing deb-src for: ## Ubuntu security updates. Aside from URIs and Suites,
  ## this should mirror your choices in the previous section.
  Types: deb-src
  URIs: http://security.ubuntu.com/ubuntu
  Suites: plucky-security
  Components: multiverse restricted universe main
  Signed-By: /usr/share/keyrings/ubuntu-archive-keyring.gpg
  Hit:1 http://archive.ubuntu.com/ubuntu plucky InRelease
  Hit:2 http://security.ubuntu.com/ubuntu plucky-security InRelease
  Hit:3 http://archive.ubuntu.com/ubuntu plucky-updates InRelease
  Hit:4 http://archive.ubuntu.com/ubuntu plucky-backports InRelease
  Reading package lists... Done
  ```

  Only after using -ss do I get the behavior I'm after.

  It used to work out of the box because the old source.list had the commented out deb-src line, but we don't have those anymore in the brave new world of deb822, so we probably reconsider this requirement altogether.
  I actually think it was surprising behavior beforehand but I didn't care much since the default case was covered.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2093420/+subscriptions