[Bug 2069391] Re: debsums reports file changed /usr/lib/systemd/system/cloud-init.service

[Nick Rosbrook]

A couple clarifying questions below.

> [ Impact ]
>  * This is a hardware enablement SRU.

How? What hardware is being enabled by this?

In debian/changelog, there is:

> * Update the overridden copy of cloud-init.service

and I see new additions of a couple Condition*= properties in the
override (along with re-ordering/placement of existing After=/Before=).
The changes *seem* reasonable enough, but why are they not discussed in
the impact, test plan, or regression potential section? Is there some
other bug that should be included in the SRU?

Without justifying and testing the change, it is not acceptable for SRU.


** Changed in: livecd-rootfs (Ubuntu Noble)
       Status: Fix Committed => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2069391

Title:
  debsums reports file changed /usr/lib/systemd/system/cloud-
  init.service

Status in cloud-init package in Ubuntu:
  Invalid
Status in livecd-rootfs package in Ubuntu:
  Fix Released
Status in subiquity package in Ubuntu:
  Invalid
Status in cloud-init source package in Noble:
  Invalid
Status in livecd-rootfs source package in Noble:
  Incomplete
Status in subiquity source package in Noble:
  Invalid

Bug description:
  [ Impact ]

   * This is a hardware enablement SRU.
   * Without the fix, /usr/lib/systemd/system/cloud-init.service is modified by livecd-rootfs in Desktop live ISOs in a way that causes `debsums -c` to fail.
   * Failing the debsums test prevents the hardware certification of the platform.

  [ Test Plan ]

  1. Download Noble Desktop daily image from cdimage: https://cdimage.ubuntu.com/noble/daily-live/current/.
  2. Boot the ISO in a VM, install the system, run `sudo apt install -y debsums && sudo debsums -c`, see the problem.
  3. Create a Live Noble Desktop ISO with the proposed livecd-rootfs version.
  4. Run the new image, install it. Verify the the cloud-init file is not corrupted anymore. run:
      - `sudo apt install -y debsums && sudo debsums -c`
      - `sudo cloud-init query --all` and see if it suceed
      - retrieve `/var/lib/cloud/instance/user-data.txt` to use it in step 5.
      - `journalctl -u cloud-init.service` and verify that there are no errors.
  5. Run the same image again. This time, apply the autoinstall configuration retrieved before. Verify that it was able to autoinstall correctly.

  [ Where problems could occur ]

   * Since the diff touches to cloud-init configuration, the risk would
  be to break cloud-init. This is why the test plan tests cloud-init
  specifically. Any other cloud-init testing strategies are welcome.

  ------ Original description -----------

  [Summary]
  debsums reported /lib/systemd/system/cloud-init.service was changed.
  Also the cloud-init.service mentioned it was auto-generated by installer build process.

  The diff output from package included and system installed.
  $ diff ./extract-cloud-init/lib/systemd/system/cloud-init.service /lib/systemd/system/cloud-init.service
  0a1,2
  > # Automatically generated by installer build process
  > # Based on cloud-init 23.1 for Desktop LiveCD
  8a11,13
  > # Installer Added After=NetworkManager* ordering
  > After=NetworkManager.service
  > After=NetworkManager-wait-online.service
  13c18
  < Before=sysinit.target
  ---
  > # Before=sysinit.target  Installer removed to allow for NM dependency
  16,18c21
  < ConditionPathExists=!/etc/cloud/cloud-init.disabled
  < ConditionKernelCommandLine=!cloud-init=disabled
  < ConditionEnvironment=!KERNEL_CMDLINE=cloud-init=disabled
  ---
  > Before=systemd-user-sessions.service

  [Steps to reproduce]
  1. Install Ubuntu 24.04 desktop
  2. Excute command `debsums -c`

  ProblemType: Bug
  DistroRelease: Ubuntu 24.04
  Package: cloud-init 24.1.3-0ubuntu3
  ProcVersionSignature: Ubuntu 6.8.0-35.35-generic 6.8.4
  Uname: Linux 6.8.0-35-generic x86_64
  ApportVersion: 2.28.1-0ubuntu2
  Architecture: amd64
  AutoInstallUserData: Error: [Errno 13] Permission denied: '/var/log/installer/autoinstall-user-data'
  CasperMD5CheckResult: pass
  CurtinConfigCurtHooks: Error: [Errno 13] Permission denied: '/var/log/installer/curtin-install/subiquity-curthooks.conf'
  CurtinConfigExtract: Error: [Errno 13] Permission denied: '/var/log/installer/curtin-install/subiquity-extract.conf'
  CurtinConfigInitial: Error: [Errno 13] Permission denied: '/var/log/installer/curtin-install/subiquity-initial.conf'
  CurtinConfigPartitioning: Error: [Errno 13] Permission denied: '/var/log/installer/curtin-install/subiquity-partitioning.conf'
  Date: Fri Jun 14 13:57:57 2024
  InstallationDate: Installed on 2024-05-02 (43 days ago)
  InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Release amd64 (20240424)
  InstallerCloudCfg: Error: [Errno 13] Permission denied: '/etc/cloud/cloud.cfg.d/99-installer.cfg'
  PackageArchitecture: all
  SourcePackage: cloud-init
  SubiquityServerDebug: Error: [Errno 13] Permission denied: '/var/log/installer/subiquity-server-debug.log.3103'
  UpgradeStatus: No upgrade log present (probably fresh install)
  cloud-init-log-warnings:
   2024-05-02 07:52:44,723 - activators.py[WARNING]: Running ['netplan', 'apply'] resulted in stderr output:
   ** (generate:1042): WARNING **: 07:52:44.418: Permissions for /etc/netplan/01-network-manager-all.yaml are too open. Netplan configuration should NOT be accessible by others.
   ** (process:1041): WARNING **: 07:52:44.646: Permissions for /etc/netplan/01-network-manager-all.yaml are too open. Netplan configuration should NOT be accessible by others.
   ** (process:1041): WARNING **: 07:52:44.696: Permissions for /etc/netplan/01-network-manager-all.yaml are too open. Netplan configuration should NOT be accessible by others.
   2024-05-02 07:53:41,599 - cc_final_message.py[WARNING]: Used fallback datasource
  user_data.txt: Error: [Errno 13] Permission denied: '/var/lib/cloud/instances/iid-datasource-none/user-data.txt'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/2069391/+subscriptions