[Bug 2110970] Re: upgrade runs in desktop mode "because of key deps for ubuntustudio-desktop-core", on non-Studio

[Heinrich Schuchardt]

Building for Questing requires replacing `xml-files` by `xml_files` in
setup.cfg.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/2110970

Title:
  upgrade runs in desktop mode "because of key deps for ubuntustudio-
  desktop-core", on non-Studio

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Committed
Status in ubuntu-release-upgrader source package in Plucky:
  Fix Released

Bug description:
  [Impact]

  There is a notion of "server" and "desktop" mode in upgrades. This is
  a historical concept, with little apparent difference in behavior
  today.

  When running an upgrade in e.g. a LXD container, one normally sees in
  the logs:

  DEBUG need_server_mode(): can not find a desktop meta package or key
  deps, running in server mode

  This is expected. On upgrades to plucky, however, we see:

  DEBUG need_server_mode(): run in 'desktop' mode, (because of key deps
  for 'ubuntustudio-desktop-core')

  This is caused by the fact that DistUpgrade.cfg does not define
  ubuntustudio-desktop-core.KeyDependencies.

  This has no apparent impact on the result of the upgrade, but it is
  nonetheless wrong, and the key should be defined for consistency.

  [Test Plan]

  Test #1:

  Perform an upgrade in a LXD container from oracular to plucky:

  $ lxc launch ubuntu:oracular oracular
  $ lxc exec oracular bash
  # do-release-upgrade --proposed

  Walk through the steps of the upgrade. At the end, check
  /var/log/dist-upgrade/main.log and confirm that the following is
  found:

  DEBUG need_server_mode(): can not find a desktop meta package or key
  deps, running in server mode

  Test #2:

  Ensure that this change does not regress Studio upgrades.

  Perform an upgrade of an Ubuntu Studio desktop installation from
  oracular to plucky. Install the system on a VM in any method you wish.

  Run the upgrade:

  $ do-release-upgrade --proposed -f DistUpgradeViewKDE

  After the upgrade, confirm that the following log message is in
  /var/log/dist-upgrade/main.log:

  DEBUG need_server_mode(): run in 'desktop' mode, (because of key deps
  for 'ubuntustudio-desktop')

  [Where problems could occur]

  The KeyDependencies list is used in two places. First is to determine
  the result of need_server_mode(). The absence of ubuntustudio-desktop-
  core.KeyDependencies *is* this bug, and is what this fix/test plan
  addresses.

  The other use is to guess the metapackage if it is not installed. This
  fix should also address a potential scenario where a Studio
  installation accidentally removed ubuntustudio-desktop-core.

  Future problems would be related to need_server_mode(), and the
  metapackage installation guessing. As with any configuration change
  like this, typos would mean the fix is incomplete. The test plans
  inspect logs to ensure consistency.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/2110970/+subscriptions