[Bug 2080499] Re: /usr/share/apport/apport:ProcessLookupError:/usr/share/apport/apport at 1248:main:_check_global_pid_and_forward:forward_crash_to_container

[Anshul Singh]

** Description changed:

+ [Original Report]
+ 
  ```
  Traceback (most recent call last):
    File "/usr/share/apport/apport", line 1248, in <module>
      sys.exit(main(sys.argv[1:]))
               ^^^^^^^^^^^^^^^^^^
    File "/usr/share/apport/apport", line 773, in main
      if _check_global_pid_and_forward(options):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/share/apport/apport", line 732, in _check_global_pid_and_forward
      forward_crash_to_container(options)
    File "/usr/share/apport/apport", line 531, in forward_crash_to_container
      sock_fd = os.open(
                ^^^^^^^^
  ProcessLookupError: [Errno 3] No such process: 'root/run/apport.socket'
  ```
  
  Example /proc/cmdline:
  
  /usr/bin/python3 /usr/share/apport/apport -p1 -s4 -c0 -d1 -P570846
  -u1000 -g1000 -- !snap!chromium!2934!usr!lib!chromium-browser!chrome
  
  /usr/bin/python3 /usr/share/apport/apport -p1 -s4 -c0 -d1 -P22550 -u1001
  -g1001 -- !snap!brave!438!opt!brave.com!brave!brave
  
  The Ubuntu Error Tracker has been receiving reports about a problem regarding apport.  This problem was most recently seen with package version 2.28.1-0ubuntu3.1, the problem page at https://errors.ubuntu.com/problem/b7c6a639ac46aadb8076c65d2ceaecc34e2aa46e contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.
+ 
+ [ Impact ]
+ 
+  * Commit 2bdffe076839 ("Switch from chroot to container to validating
+ socket owner") that fixes CVE-2022-1242, CVE-2022-28657 causes a
+ security update regression so Python emits a ProcessLookupError instead
+ of FileNotFoundError.
+ 
+  * The upload fixes the bug as we now include the ProcessLookupError
+ exception so that we have the correct logs for the error.
+ 
+ [ Test Plan ]
+ 
+  * This crash can be reproduced by killing chromium (killall -11
+ chrome).
+ 
+ ```
+ Traceback (most recent call last):
+   File "/usr/share/apport/apport", line 1248, in <module>
+     sys.exit(main(sys.argv[1:]))
+              ^^^^^^^^^^^^^^^^^^
+   File "/usr/share/apport/apport", line 773, in main
+     if _check_global_pid_and_forward(options):
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   File "/usr/share/apport/apport", line 732, in _check_global_pid_and_forward
+     forward_crash_to_container(options)
+   File "/usr/share/apport/apport", line 531, in forward_crash_to_container
+     sock_fd = os.open(
+               ^^^^^^^^
+ ProcessLookupError: [Errno 3] No such process: 'root/run/apport.socket' 
+ ```
+ 
+ The Snap container neither has /run nor /run/apport.socket
+ 
+ [ Where problems could occur ]
+ 
+  * Just adding exception handling for ProcessLookupError so it's a
+ really small change, the only issue I can imagine is a syntax error
+ which makes crashes apport
+ 
+ * Since apport is primarily for crash reports, user experience is
+ unlikely to be affected much
+ 
+ [ Other Info ]
+ 
+  * A small caveat is that the proposed fix doesn't have a test case
+ covering this part of the code

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/2080499

Title:
  /usr/share/apport/apport:ProcessLookupError:/usr/share/apport/apport at 1248:main:_check_global_pid_and_forward:forward_crash_to_container

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Jammy:
  New
Status in apport source package in Noble:
  New
Status in apport source package in Oracular:
  New
Status in apport source package in Plucky:
  New

Bug description:
  [Original Report]

  ```
  Traceback (most recent call last):
    File "/usr/share/apport/apport", line 1248, in <module>
      sys.exit(main(sys.argv[1:]))
               ^^^^^^^^^^^^^^^^^^
    File "/usr/share/apport/apport", line 773, in main
      if _check_global_pid_and_forward(options):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/share/apport/apport", line 732, in _check_global_pid_and_forward
      forward_crash_to_container(options)
    File "/usr/share/apport/apport", line 531, in forward_crash_to_container
      sock_fd = os.open(
                ^^^^^^^^
  ProcessLookupError: [Errno 3] No such process: 'root/run/apport.socket'
  ```

  Example /proc/cmdline:

  /usr/bin/python3 /usr/share/apport/apport -p1 -s4 -c0 -d1 -P570846
  -u1000 -g1000 -- !snap!chromium!2934!usr!lib!chromium-browser!chrome

  /usr/bin/python3 /usr/share/apport/apport -p1 -s4 -c0 -d1 -P22550
  -u1001 -g1001 -- !snap!brave!438!opt!brave.com!brave!brave

  The Ubuntu Error Tracker has been receiving reports about a problem regarding apport.  This problem was most recently seen with package version 2.28.1-0ubuntu3.1, the problem page at https://errors.ubuntu.com/problem/b7c6a639ac46aadb8076c65d2ceaecc34e2aa46e contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

  [ Impact ]

   * Commit 2bdffe076839 ("Switch from chroot to container to validating
  socket owner") that fixes CVE-2022-1242, CVE-2022-28657 causes a
  security update regression so Python emits a ProcessLookupError
  instead of FileNotFoundError.

   * The upload fixes the bug as we now include the ProcessLookupError
  exception so that we have the correct logs for the error.

  [ Test Plan ]

   * This crash can be reproduced by killing chromium (killall -11
  chrome).

  ```
  Traceback (most recent call last):
    File "/usr/share/apport/apport", line 1248, in <module>
      sys.exit(main(sys.argv[1:]))
               ^^^^^^^^^^^^^^^^^^
    File "/usr/share/apport/apport", line 773, in main
      if _check_global_pid_and_forward(options):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/share/apport/apport", line 732, in _check_global_pid_and_forward
      forward_crash_to_container(options)
    File "/usr/share/apport/apport", line 531, in forward_crash_to_container
      sock_fd = os.open(
                ^^^^^^^^
  ProcessLookupError: [Errno 3] No such process: 'root/run/apport.socket' 
  ```

  The Snap container neither has /run nor /run/apport.socket

  [ Where problems could occur ]

   * Just adding exception handling for ProcessLookupError so it's a
  really small change, the only issue I can imagine is a syntax error
  which makes crashes apport

  * Since apport is primarily for crash reports, user experience is
  unlikely to be affected much

  [ Other Info ]

   * A small caveat is that the proposed fix doesn't have a test case
  covering this part of the code

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/2080499/+subscriptions