[Bug 2107692] Re: [SRU] Asus Vivobook S15 hwe-qcom-x1e-meta modsignature doesn't work

[Robie Basak]

Matrix thread here:
https://matrix.to/#/!slcYrFqWytcsbPzMxA:ubuntu.com/$AckEpDt1KN9Ksdqb_jx9t_5STrvG_VX9wVlhV3t7SUw?via=ubuntu.com&via=matrix.org&via=matrix.debian.social

I wondered why we are fixing this in Plucky given that we expect to
never spin a new installer image. Tobias stated "as I understand the
mechanism ubuntu-drivers will look at the local modalias signatures and
then check them against the apt cache to see if it needs to install
additional driver packages" so this is difficult/impractical to test
before landing into plucky-updates. I have asked that we exceptionally
do a full test of the user story after releasing into plucky-updates to
make sure the fix has landed correctly.

** Tags added: verification-needed verification-needed-plucky

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-x1e-settings in Ubuntu.
https://bugs.launchpad.net/bugs/2107692

Title:
  [SRU] Asus Vivobook S15 hwe-qcom-x1e-meta  modsignature doesn't work

Status in ubuntu-x1e-settings package in Ubuntu:
  Fix Released
Status in ubuntu-x1e-settings source package in Plucky:
  Fix Committed
Status in ubuntu-x1e-settings source package in Questing:
  Fix Released

Bug description:
  [ Summary ]

  hwe-qcom-x1e-meta should automatically get installed during Ubuntu
  installation on supported laptops. This works by using modalias
  signatures in d/hwe-qcom-x1e-meta.modaliases which ubuntu-drivers uses
  to find supported driver packages.

  The current matching pattern for the Asus Vivobook is:
    dmi:bvnASUSTeKCOMPUTERINC.:*:pnASUSVivobookS15*

  This is incorrect, since bvn is the BIOS vendor field which is not actually ASUS. The actual content of /sys/devices/virtual/dmi/id/modalias on the laptop is:
  dmi:bvnInsyde:bvrS5507QAD.362:bd12/26/2024:br3.7:efr3.9:svnASUSTeKCOMPUTERINC.:pnASUSVivobookS15S5507QA_S5507QAD:pvr1.0:rvnASUSTeKCOMPUTERINC.:rnS5507QAD:rvr1.0:cvnASUSTeKCOMPUTERINC.:ct10:cvr1.0:sku(null):

  This is easily fixed by adjusting the pattern to sth like:
    dmi:*:svnASUSTeKCOMPUTERINC.:pnASUSVivobookS15*

  [ User Impact ]

  user tries to install Ubuntu 25.04 on an Asus Vivobook. Installer
  boots and everything looks fine but when they try to boot into the
  installed system it won't work. This is because the modalias didn't
  match, the ubuntu-x1e-settings package wasn't automatically installed
  and now they are missing configuration files without which the system
  won't boot.

  [ Test Plan ]

  Someone with access to the hardware can verify the validity of the new pattern with the following script:
  for l in $(find /sys -name modalias -print0 | xargs -0 cat); do if [[ $l == dmi:*:svnASUSTeKCOMPUTERINC.:pnASUSVivobookS15* ]]; then echo $l; fi; done

  Once a fix is in proposed, "ubuntu-drivers list" should return hwe-
  qcom-x1e-meta on the affected machine with proposed enabled.

  Testing the -proposed package in the installer might be tricky and not feasible.
  Instead, since the fix is already in Questing, I propose we ask someone with access to the hardware to test if the Questing daily image installation works as expected and use that as confirmation that the fix works.
  I asked for test feedback on discourse, see https://discourse.ubuntu.com/t/ubuntu-24-10-concept-snapdragon-x-elite/48800/931

  Once the changes are in 25.04 we can also ensure that the installer
  there works as expected.

  [ Regression Potential ]
  Close to none. The current pattern doesn't work, a patch would only touch that. In the worst case it will still not work, it can't affect any other devices.

  [ References ]
  Previous discussion on discourse:
  https://discourse.ubuntu.com/t/ubuntu-24-10-concept-snapdragon-x-elite/48800/865

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-x1e-settings/+bug/2107692/+subscriptions